Openshot-qt: Can't rotate videos to original position when "Rotation" present in metadata.

[tofran]

Description:
When a video has a non zero Rotation in its metadata its impossible to rotate it to its original position.

EXIF causing the issue:

Rotation                        : 90

Steps to reproduce:

1. On your phone start recording a video vertically and then flip it to horizontal
2. Add that video to the timeline
3. Right click it > rotate
4. Both "No Rotation" and "Rotate 90 (Right)" will keep the video vertical (all other options will not flip it to the desired orientation)

Expected behavior:
The video should be flipped to horizontal.

System Details:

• OpenShot Version [v2.4.4]: OpenShot-v2.4.4-x86_64
  also tried with build dev1-1558038193-42af4ca8-9a1a6093
• Video camera: Oneplus 6

Demo:

Video Sample
unrotatabe-video.mp4

Related issues:
I'll link here some issues that may be related, but lack information:

2784

2785

2700

2629

[peanutbutterandcrackers]

@tofran - Thank you for the well-written report. I will try to get the devs to look into this. :+1:

[SuslikV]

Possible workaround.
In the _Properties_ of the selected clip set _Rotation_ to very small value, for example: 0,00000000000000000001 thus clip will rotate at desirable position, the simple 0 won't work - just a bug.

[rredford]

I used 0.001 which was small enough to round to zero. Annoying though.

[SuslikV]

@rredford this is kind of "optimization" in OpenShot. It intended to skip unneeded transform during rendering and thus, to increase the rendering speed. This is complex bug, not just UI.

Related check is seems to be here (libopenshot library): https://github.com/OpenShot/libopenshot/blob/a8d545ea92a8a061b0117a2ff6e7a1a78d818c1f/src/Timeline.cpp#L521
Default rotation value of 90 degree (unrotatabe-video.mp4 few posts above) was set during read of the media file, so by rotating it even more you can make 0 degree total (no rotation).

But why my 0,00000000000000000001 works here too?!! It's a big question for me...

[rredford]

I did not state what source of bug was, not saying if it was UI bug nor complex bug or anything. Not sure what you are trying to correct.

[stale[bot]]

Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.
This issue will be closed, as it meets the following criteria: - No activity in the past 180 days - No one is assigned to this issue
We'd like to ask you to help us out and determine whether this issue should be reopened. - If this issue is reporting a bug, please can you attempt to reproduce on the latest daily build to help us to understand whether the bug still needs our attention. - If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.
Thanks again for your help!

[tofran]

I don't think this issue should be closed for lack of activity.
This is a breaking bug that prevents non-technical people from using openshot.