Openshift-ansible: Rerunning openshift-logging fails on patch command when rerunning

[jmontleon]

Description

Rerunning openshift-logging fails on patch command when rerunning:

Version

openshift-ansible master
ansible-2.5.0-2.el7.noarch

Steps To Reproduce

1. Install openshift-logging with the openshift-logging modules
2. Rerun the modules

Expected Results

Rerunning the modules to complete successfully.

Observed Results

TASK [openshift_logging : logging_patch] ***************************************
ok: [localhost]
TASK [openshift_logging : slurp] ***********************************************
ok: [localhost]
TASK [openshift_logging : copy] ************************************************
changed: [localhost -> localhost]
TASK [openshift_logging : copy] ************************************************
changed: [localhost -> localhost]
TASK [openshift_logging : command] *********************************************
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "cmd": "patch --force --quiet -u /tmp/openshift-logging-ansible-gIOFzm/configmap_new_file /tmp/openshift-logging-ansible-gIOFzm/patch.patch", "msg": "[Errno 2] No such file or directory", "rc": 2}
    to retry, use: --limit @/opt/apb/actions/provision.retry
PLAY RECAP *********************************************************************
localhost                  : ok=129  changed=44   unreachable=0    failed=1  

[ewolinetz]

We've seen this before, it is due to patch not being available on the control host.
Its strange if this manages to run the first time but fails on a second execution (I haven't seen that locally...)

[jmontleon]

Ah, that makes sense. I may just need to install it in the container. It would be great if it was that simple.

[jmontleon]

That's all it was. I rebuilt the image to include the patch command and it worked fine.

Thanks!

[nagonzalez]

This exact thing happened to me as well. Should we call this out as a requirement in the documentation and/or codify this in a playbook?

Fedora 28

git describe
openshift-ansible-3.9.38-1-4-g78df90b40

ansible --version
ansible 2.6.1
  config file = /opt/openshift-ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.6 (default, Jul 19 2018, 14:25:17) [GCC 8.1.1 20180712 (Red Hat 8.1.1-5)]

[nagonzalez]

Nevermind. It's documented. I missed it.