Openshift-ansible: sanity-check removed vars problem

[thebithead]

Description

I appears that a recent commit (d3da3edab71cec3c1e54a3b6b0ce4391bbb70de8) broke my OpenShift install (which was working yesterday).

    default: Failure summary:                                                   
    default:                                                                    
    default:                                                                    
    default:   1. Hosts:    10.0.2.15                                           
    default:      Play:     Verify Requirements                                 
    default:      Task:     Run variable sanity checks                          
    default:      Message:  last_checked_host: 10.0.2.15, last_checked_var: openshift_master_identity_providers;Found removed variables: openshift_node_kubelet_args is replaced by openshift_node_groups[<item>].edits; 

Version

Please put the following version information in the code block
indicated below.

[root@centos7 vagrant]# ansible --version
ansible 2.6.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/sh\
are/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Oct 30 2018, 23:45:53) [GCC 4.8.5 20150623 (\
Red Hat 4.8.5-36)]
[root@centos7 vagrant]# 

If you're operating from a git clone:

[root@centos7 openshift-ansible]# git describe
openshift-ansible-3.11.73-1-6-g172fc73
[root@centos7 openshift-ansible]# 

If you're running from playbooks installed via RPM

• The output of rpm -q openshift-ansible

Place the output between the code block below:

VERSION INFORMATION HERE PLEASE

Steps To Reproduce

From a clean CentOS7 box:

    yum -y update
    yum -y install emacs git
    cd /home/vagrant
    wget --quiet https://github.com/openshift/origin/releases/download/v3.11.0/\
openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit.tar.gz
    tar -xzf openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit.tar.gz
    echo "export PATH=/home/vagrant/openshift-origin-client-tools-v3.11.0-0cbc5\
8b-linux-64bit:$PATH" >> /home/vagrant/.bashrc
    source /home/vagrant/.bashrc
    git clone https://github.com/gshipley/installcentos.git
    export ETH1_IP=$(/sbin/ifconfig eth1 | awk -F'[ :]+' '/inet /{print $3}')
    export DOMAIN=${ETH1_IP}.xip.io
    export USERNAME=admin
    export PASSWORD=admin123
    export INTERACTIVE=false
    printenv
    echo "##start install-openshift"
    cd /home/vagrant/installcentos
    ./install-openshift.sh 2>&1 | tee $HOME/install-openshift.log
    echo "##end install-openshift"

Expected Results

Successful install of OpenShift.

Observed Results

Describe what is actually happening.

    default: TASK [Run variable sanity checks] ********************************\
**************
    default: fatal: [10.0.2.15]: FAILED! => {"msg": "last_checked_host: 10.0.2.\
15, last_checked_var: openshift_master_identity_providers;Found removed variabl\
es: openshift_node_kubelet_args is replaced by openshift_node_groups[<item>].ed\
its; "}
    default:    to retry, use: --limit @/home/vagrant/installcentos/openshift-a\
nsible/playbooks/prerequisites.retry                                            
    default:       

For long output or logs, consider using a gist

Additional Information

Provide any additional information which may help us diagnose the
issue.

• Your operating system and version, ie: RHEL 7.2, Fedora 23 ($ cat /etc/redhat-release)
• Your inventory file (especially any non-standard configuration parameters)
• Sample code, etc

[root@centos7 openshift-ansible]# cat /etc/redhat-release
CentOS Linux release 7.6.1810 (Core)
[root@centos7 openshift-ansible]# 

[vrutkovs]

Do you have openshift_node_kubelet_args set in the inventory?

[thebithead]

@vrutkovs Yes.

[root@centos7 installcentos]# grep openshift_node_kubelet_args inventory.ini
openshift_node_kubelet_args={'pods-per-core': ['10']}
[root@centos7 installcentos]# 

[vrutkovs]

Right, that variable doesn't do anything, thus the error is thrown.

@gshipley seems https://github.com/gshipley/installcentos.git should not have openshift_node_kubelet_args set anymore

[DarkMukke]

@vrutkovs created a PR in his repo.

[vrutkovs]

Thanks, closing the issue here