Openscope: Compass rose is misaligned

[erikquinn]

The compass rose displayed when an aircraft is selected is not aligned properly; it should be aligned relative to the position of the selected aircraft; instead it is relative to the airport.

Originally reported in zlsa/atc#718.

[erikquinn]

Additionally, this would be one of the things that should be enabled/disabled in the settings menu (defaulted to _off_).

[felixscheffer]

Issue still exists:

[n8rzz]

Hmm, fooled by .shouldDeepRender() again. I was under the impression we had removed it. As my esteemed colleague @felixscheffer has pointed out, we have not. One thing of note is that the compass isn't visible unless you have an aircraft selected _and_ trigger a deep render (pan/zoom).

The big question here is: do we still want to support this compass? I don't think it provides a whole lot of value and it's pretty expensive to draw every frame (when an aircraft is selected). What do the real scopes (or even IVAO) do here?

[felixscheffer]

At least it should be rendered when you select an aircraft.

[felixscheffer]

45 is probably the way to go.

[n8rzz]

agreed. that gets us closer to reality

[erikquinn]

I'm okay with axing it. It _is_ helpful for people still getting used to estimating headings though. It's just not worth a lot of work to keep it.

I will say it didn't seem like it would be too rough to fix. Just find where it uses the center, and move it, and whatever ugly logic it has should still work.

Either way!