Openrefine: "Clear reconciliation data" not clearing all reconciliation data

[tfmorris]

_Original author: danpaulsmith (March 05, 2012 10:28:35)_

Hi,

I've noticed that after clicking the menu item "Clear all reconciliation data" for a column - the column object in the columnModel still has the properties "reconConfig" and "reconStats" - which are both populated.

The extension we're working on attempts to detect whether the user has reconciled columns previously by looking for columns that have the "reconConfig" and "reconStats" properties.

If the user decides to clear their reconciliation data - these properties do not disappear - which as a result, looks like they are not clearing their reconciliation data.

Dan

_Original issue: http://code.google.com/p/google-refine/issues/detail?id=545_

[tfmorris]

_From danpaulsmith on March 05, 2012 10:33:24:_
version 2442

[tfmorris]

_From danpaulsmith on April 24, 2012 15:37:28:_
Hi David,

Any progress on this?

Thanks,
Dan

[tfmorris]

_From [email protected] on May 02, 2012 07:44:36:_
Sorry, Dan, I haven't had a chance to start working on it.

[thadguidry]

@wetneb Do we have tests for this and they pass? If so, then we can close this issue.

[wetneb]

If you found tests for this, can you paste a link to them?

[thadguidry]

https://github.com/OpenRefine/OpenRefine/blob/150ee12058e1503771e946090d041cca7ba80523/main/tests/server/src/com/google/refine/tests/operations/recon/ReconClearSimilarCellsOperationTests.java

https://github.com/OpenRefine/OpenRefine/blob/150ee12058e1503771e946090d041cca7ba80523/main/tests/server/src/com/google/refine/tests/operations/recon/ReconDiscardJudgmentsOperationTests.java

[wetneb]

@thadguidry these tests do not check the behaviour of the operations, they only check JSON serialization.

[ostephens]

I don't understand what the requirement is here. @thadguidry do you have a clear idea of what the behaviour should be when a user selects to "Clear reconciliation data"?

[thadguidry]

It used to clear (reset) the matched id's. Effectively (and destructively) removing all matched id's as well as proposed candidate matches. This would also show up visually as the green bar for "left to reconcile" was completely clear. User's would have to start from scratch again to reconcile. If I recall, when you did cell.recon on a column after you cleared data, it was None typed in the output?

[ostephens]

That's what it does currently. My reading of this issue is that the requester wanted it to not only clear the matches/proposed matches, but also remove the "reconConfig" and "reconStats" properties - but I don't understand the reasons beyond "we are writing an extension that will look at these properties for some reason"

Given this was first requested in 2012 I think we could assume the extension has either been written or abandoned (or both!) in the meantime.

My vote would be to just close this now as changing the behaviour without understanding the requirement seems like a bad idea

[thadguidry]

Agreed. Thanks Owen.