Openrefine: List Facets dialogue box is editable

[kushthedude]

Describe the bug

List Facets dialogue box is editable, which should not be.

To Reproduce
Steps to reproduce the behavior:

1. Go to Customised Facets
2. Click on Word Facet
3. List all choices
4. See error

Current Results

You can edit the dialogue and remove or add anything which should not be applicable as it is listing the facets.

Screenshots

[kushthedude]

cc: @thadguidry @wetneb

[thadguidry]

@kushthedude Historical context: This was originally allowed by design. User's sometimes wanted to quickly rename something and then do CTRL-A to select everything in the box and CTRL-C to copy the info so that they could paste it CTRL-V into another program.

Given that context, do you see a problem currently with this historical use case now? You said "see error" but you didn't explain or show what the error is.

[kushthedude]

I don't see the context of renaming and editing in here. As after editing none of the changes are applied to the actual list of facets.

You said "see error" but you didn't explain or show what the error is.

I mentioned in the bug description that the text box should is editable where it should be not. It may just allow to list all available word filter facets for users to see the options ?

[kushthedude]

User's sometimes wanted to quickly rename something

@thadguidry What advantage would renaming give to the users when the words available are already defined in the datasets?
It actually didn't seem logical to me as if the user is listing out and seeing the avaialble list of words which he can use to apply the filter why would he want to rename any of them, I may be wrong but if there is any use-case or an advantage of editable list, I will close the issue and it's relevant PR.

[thadguidry]

@kushthedude It was not intended to CHANGE facets, but instead to allow users to EXPORT or as David said in the commit "Copy off" the data contained within facets...via copy/paste. You can see the git blame's and issues from the git history. Specifically, https://github.com/OpenRefine/OpenRefine/commit/066fed7f3db00e7c0d84174aa26bde59dfd40a37

[kushthedude]

@kushthedude It was not intended to CHANGE facets, but instead to allow users to EXPORT or as David said in the commit "Copy off" the data contained within facets...via copy/paste. You can see the git blame's and issues from the git history. Specifically, 066fed7

Yes, that's what I am saying over here. As seen from the commit the list feature was introduced to let users copy the list of choices and there count from the total available. But there is no need to make that list editable since this is a list and it should be read-only from which user can select and copy/paste the data he needs. Also making the list box editable may result into some human errors like typing of extra keywords or removal of any letter by accidental key presses which may result in wrong copy/paste.

It was not intended to CHANGE facets

That's what I am highlighting making the list editable may seem to user that changing the word in the list textbox may result in changing the options available. Hence the list box should be read-only which may only list the options and their count with the ability for the user to copy/paste the data into a new program!

[thadguidry]

@kushthedude Sure, just giving you the context... a few users wanted to edit in the box quickly and then copy. Changing this means they will just be allowed to copy and can make edits in another program. (we might upset those very few users) I'm actually fine with not allowing edits in OpenRefine here and letting them edit in their own Notepad.

We could also change the title and put a smaller subtitle under it that explains more "This dialog allows you to copy the facet values (use ctrl-c) to paste into other programs"

One of the reasons I personally like Vue.js is that our whole dialog system could be much more guided with Help and Hints. Vue.js makes this easier than other frameworks from what I've seen. Anyways...I digress.

[kushthedude]

@kushthedude Sure, just giving you the context... a few users wanted to edit in the box quickly and then copy. Changing this means they will just be allowed to copy and can make edits in another program. (we might upset those very few users) I'm actually fine with not allowing edits in OpenRefine here and letting them edit in their own Notepad.

I understand your use-case now. Now as we are again in the dilemma of making the textbox read-only or editable. Let's wait for another opinion from @wetneb, if the editable textbox is more beneficial then I will close the issue and it's relevant PR :).

We could also change the title and put a smaller subtitle under it that explains more "This dialog allows you to copy the facet values (use ctrl-c) to paste into other programs"

Yeah, this will clear the use-case of the dialogue to users.

[kushthedude]

One of the reasons I personally like Vue.js is that our whole dialog system could be much more guided with Help and Hints. Vue.js makes this easier than other frameworks from what I've seen. Anyways...I digress.

I will start working today on introducing the Vue.js to a part of our web-app as discussed in gitter and let's see how it goes 😅