Openfoodnetwork: Missing translation '(includes tax)' on cart page

[drummer83]

Description

The translation key for '(includes tax)' on the cart page is missing.

Steps to Reproduce

1. Set language to non-English
2. Put item into your cart
3. Go to https://openfoodnetwork.de/cart

Animated Gif/Screenshot

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: v3.5.11
• Browser name and version: Firefox 86
• Operating System and version (desktop or mobile): Desktop Windows 10

[drummer83]

I leave you to confirm that this is a s3.

[sigmundpetersen]

Yes, missing translations are s3. We also have an epic where we collect all translation bugs 👍

[RachL]

They also are good first issues and need to be added to the welcome new dev board :+1:

[drummer83]

Isn't this frontend, @RachL?

[RachL]

@drummer83 it's frontoffice, but a backend issue :)

[stavares843]

I can reproduce the issue, but going to the strings file all seems correct

https://github.com/openfoodfoundation/openfoodnetwork/blob/master/config/locales/de_DE.yml#L1477

Any thoughts?

[drummer83]

Yeah, there are two occurences. The one which is in the string file is used here:
\openfoodnetwork\app\views\spree\orders_summary.html.haml
The one which is not translated is in this file here:
\openfoodnetwork\app\views\spree\orders_form.html.haml

Unfortunately I cannot open the cart in my test environment (don't know why) so I cannot fix and test it myself.

[guidoDutra]

Hello! I'd like to take this issue as my first PR, I talked to Lynne Davis and have been told to comment here to get it assigned to me

[sigmundpetersen]

Hey @guidoDutra thanks! I assigned you and moved the issue to 'In Dev' on the Zenhub board.

[guidoDutra]

thanks @sigmundpetersen!

[drummer83]

Hey @guidoDutra,
sorry,isthis a duplicate which has just been solved? #7057

[andrewpbrett]

Hi @guidoDutra, sorry about that - @drummer83 is correct, this was just fixed. Let me know if you want any guidance on finding another good first issue to work on.

[guidoDutra]

No problem @AndrewCleve , I'll pick up another issue later. If you have any recommendation let me know, otherwise I'll choose by myself