Openfoodnetwork: Missing/wrong translation key in admin / new order

[RachL]

Description

When creating a new order as an admin, the word is not correct in French, so I suspect that we reuse another key here instead of having a dedicate one.

Steps to Reproduce

1. Go to /admin/orders/new
2. The translation key for the title is not correct

Animated Gif/Screenshot

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: v2.8
• Browser name and version: Firefox 73
• Operating System and version (desktop or mobile): Desktop

[sharonfruit]

Looking into this issue.

[sigmundpetersen]

Great thanks @sharonfruit. I moved it to In Dev for you.
Please don't hesitate to ask if you have any questions.

There's also a section on i18n in the wiki here https://github.com/openfoodfoundation/openfoodnetwork/wiki/Internationalisation-%28i18n%29#development

[RachL]

Hello @sharonfruit I hope you are doing fine. Are you still planning to work on this?

[sharonfruit]

Hi @RachL , I did track the root cause of this issue down to the app/views/spree/admin/orders/set_distribution.html.haml file (unexpectedly not app/views/spree/admin/orders/index.html.haml) where the translation for "new" is being prepended to the page_title and order number that is set in the shared app/views/spree/admin/shared/_order_tabs.html.haml.

A translation key for "new order" does exist but removing the "order" translation from the _order_tabs.html.haml page_title affects every other page that renders this shared element. At that point I was unsure of the preferred way to resolve the issue and was sidetracked by other work.

I will ask in the #dev channel for advice on the best way to resolve.

[RachL]

hey @sharonfruit ! Did you get any feedback? Are you still planning to work on this?

[RachL]

As there seem to be no activity here, I'm moving it back to the list of available issues.

[rmklaus12]

I'll grab this!

[sharonfruit]

@rmklaus12 My Docker image is broken at the moment, but I made a pull request for what I had. Feel free to trash and start over or to use it and modify.

@RachL sorry I couldn't devote as much time to this as I wanted. I agree it's best that you re-assigned.

[rmklaus12]

Happy to take over @sharonfruit. :-)

[rmklaus12]

I believe the fix is in place. @RachL - can you please confirm based on these screenshots, that this is the wording you want? I have changed other files based on @luisramos0 suggestion to the other dev, so will push all changes and open a PR if you are happy with this bit. Thanks!

[RachL]

looking good thanks @rmklaus12 !