Openfoodnetwork: Add red * on all the mandatory fields when creating a new OC

Created on 10 Jun 2019  路  8Comments  路  Source: openfoodfoundation/openfoodnetwork

Description

- As a: enterprise user or super admin
- On page: /admin/order_cycles/new

image.png

- I want to be able to do: Be able to see more clearly which fields are mandatory to fill in.

The current mandatory fields are:

  • Name
  • Ready for

The proposal is to add a red * besides each field name. This is what is being done on product creation:

image

This feedback came out of https://community.openfoodnetwork.org/t/some-potential-ofn-improvements-from-a-small-normandy-producer/1663/2

It will help us to show more easily that the "ready for" field is mandatory.

Acceptance Criteria

This issue can be closed if the following tests can be done:

Scenario 1

  1. Log in as an enterprise user
  2. Go to /admin/order_cycles/new
  3. You can see red * on all the mandatory fields. When they are all filled up, the update button is enhanced (current behaviour)

Scenario 2

  1. Log in as a super admin
  2. Go to /admin/order_cycles/new
  3. You can see red * on all the mandatory fields. When they are all filled up, the update button is enhanced (current behaviour)
enhancement good first issue hackathon

All 8 comments

@RachL would like to work on this one.
Should I proceed?

Hi @abhishek-iitj you are welcome! please go ahead, let us know if you have any issues with this.

Welcome in our community @abhishek-iitj ! :) Looking forward to your contribution

Hi @RachL, if this issue is back open for Hacktoberfest, I can take a look at it? I'll plan on setting up the asterisks the same way as on the product page, and adding your suggested tests, unless there are any other considerations

Hi @daningenthron ! Sure go for it :) 馃挭

Hi @RachL can you verify that 'Orders open at' and 'Orders close' should be mandatory? I see instances in the code where OCs are undated or partially dated, where one or more of these fields have null values.

Hi @daningenthron my bad indeed those fields are not mandatory yet. Let's focus here only on those who are. I will update the issue.

Got it - thanks for clarifying!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Matt-Yorkley picture Matt-Yorkley  路  3Comments

filipefurtad0 picture filipefurtad0  路  3Comments

shen-sat picture shen-sat  路  3Comments

HugsDaniel picture HugsDaniel  路  3Comments

filipefurtad0 picture filipefurtad0  路  3Comments