Openfoodnetwork: Release v1.30

[luisramos0]

TBD

[sauloperez]

We'll prepare the release today and test it throughout the week.

[sauloperez]

This is the build we'll use: https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/branches/master/builds/588

[sauloperez]

Release ready to be tested at https://github.com/openfoodfoundation/openfoodnetwork/releases/tag/untagged-f58a56110720c5e7a9e5 cc @RachL

[RachL]

Here are my testing notes:
https://docs.google.com/document/d/1Z6JBWjQhVxZGCPzF2hecir8ePKVbmevsxHOA22U6zIU/edit#

I've introduced for the first time Paypal and BOM in the test release process.

I discovered 3 things but I don't think they are blocking the release:

• @sauloperez while retesting #3639 I've noticed that the variant does not disappear directly on the shop front. It takes some time (even incognito, with no cookies/cache etc) Is this something to considered?
• I've noticed that you could order through subs a product with insufficient stock. The stock of the product will then become negative. I have no idea if it was made on purpose. I will open a separate issue for this : #3713
• I couldn't checkout with my fake paypal visa card, only with "paypal balance". I think it is linked to my fake buyer paypal account. I need to investigate. @luisramos0 when you tested did you used the visa card or the balance option?

[luisramos0]

great, thanks a lot for all the testing @RachL
re paypal, I cant remember!! I think I payed with my real paypal account and my real credit card!!! But on a sandbox.paypal.com URL... I am not sure...

[sauloperez]

@sauloperez while retesting #3644 I've noticed that the variant does not disappear directly on the shop front. It takes some time (even incognito, with no cookies/cache etc) Is this something to considered?

Did you probably mean #3639?

I couldn't checkout with my fake paypal visa card, only with "paypal balance". I think it is linked to my fake buyer paypal account. I need to investigate. @luisramos0 when you tested did you used the visa card or the balance option?

You mean with one of those test credit card numbers they list?

[luisramos0]

@sauloperez this needs to be looked at before releasing: https://github.com/openfoodfoundation/openfoodnetwork/pull/3694#pullrequestreview-224246651

[RachL]

@sauloperez I don't know if paypal gives a list of credit cards like stripe do, but I only tested with the fake visa card that gets created with a dev account.

[RachL]

Ah and yes #3639 definitely! Will change this in my post

[sauloperez]

I'll check again #3639 but how long did it take to disappear @RachL? Keep in mind that the cache is refreshed asyncronously, so depending on the servers load it might take few seconds.

[RachL]

2 or 3 minutes

[sauloperez]

I found the reason and it turns out it does work in v2. To avoid adding extra overhead I prefer to go ahead with the release and wait for v2. Meanwhile, I created https://github.com/openfoodfoundation/openfoodnetwork/pull/3725 to cover it with tests.

[sauloperez]

We will wait for @Matt-Yorkley to have an improved implementation on top of https://github.com/openfoodfoundation/openfoodnetwork/pull/3694. Nothing else got merge after the release draft, so there won't be need to test again.

[RachL]

Perfect! let's go :)

[Matt-Yorkley]

Updates here: #3726

[sauloperez]

3726 successfully added to https://github.com/openfoodfoundation/openfoodnetwork/releases/tag/untagged-754541ea286fa1c15fce. I also updated the link to the build on my comment above.

[sauloperez]

Release published now we just need to deploy on Monday.

[sauloperez]

Deployed to the new European group (https://github.com/openfoodfoundation/ofn-install/pull/391).

• [x] BE
• [x] UK
• [x] FR
• [x] ES
• [ ] NO
• [x] DE
• [x] CA
• [x] AU
• [x] US

[luisramos0]

@sauloperez that fabulous!
can you please update this page with the new commands?
https://github.com/openfoodfoundation/ofn-install/wiki/Current-deployment-status

thanks!

[sauloperez]

Yes. That page needs a refactor.

[RachL]

@sauloperez this issue is still open because Norway didn't update is this correct? @sigmundpetersen do you know if the update is planned?

[sigmundpetersen]

I think we need to figure out if a deploy breaks Bugsnag integration (https://github.com/openfoodfoundation/openfoodnetwork/issues/3587#issuecomment-485711303)

[sauloperez]

That server is totally out-of-date and is not managed with ofn-install either, so it is a bit tricky. Do you mind to tackle it separately @sigmundpetersen so we can close this?

[sigmundpetersen]

Yes let's keep it out of this loop for now. Let's close!