Openfoodnetwork: [mobile ux] Copy-paste in shopfront message display strange white strips

[myriamboure]

In a feature branch or master?

This can be merged straight to master 🎉

Description

When copy-pasting from another shopfront or any text file, into the "message when shopfront open/close" (in menu enterprise setting > shop preferences), here is what happens. Some shops have done that apparently and then their shopfront is not looking good.

[daniellemoorhead]

Hey @myriamboure I think this could be something a newbie could do, so would you be able to add a little bit more information about what you did / where you did it and where this message displays? I'm not sure if it would be obvious for a new person :)

[myriamboure]

Sure ! In the enterprise menu, the user write in "shopfront preference" a welcome message for his hub 1.
He creates another hub and wants to use the same welcome message. So he copies/pastes the welcome message from hub 1 to hub 2. He saves and go on the hub 2 shopfront, he sees the image above so the white strips below the text.
He is surprised so he goes back to the hub 2 menu and delete the message and retype it, but it doesn't change anything, still the white strips.
Hope it's clear enough, if any question come back to me :-)

[mllocs]

Pretty easy to reproduce, just paste a multi-paragraph text like:

paragraph1

paragraph2

and the WYSIWYG will generate a markup with a white background paragraph...

[mjal]

This seems to be fixed in the latest version of the library, copying and pasting from the editor don't add white strips anymore.

However the editor also paste the style of the text, so the example above will still highlight the text because it's inside a code segment (highlighted with a grey background)

[Matt-Yorkley]

99.9% sure this is closed by #4655. Feel free to reopen if that's not the case.

[daniellemoorhead]

@Matt-Yorkley this bug is not fixed as was expected by changing to the home tab.

I think we need to strip any background colour formatting that is copied across to the fields.

The shop where this is happening is https://openfoodnetwork.org.au/local-produce-ladies/shop#/home

[mkllnk]

@daniellemoorhead I think this is already solved. Can you check?

[daniellemoorhead]

@mkllnk here's another example of background colour displaying. https://staging.katuma.org/fredo-s-farm-hub/shop#/home

I copied text from a google doc that I had highlighted in green and that background highlight colour shows up on the tab.

[mkllnk]

Ah, great. I was able to copy that example. When I copy from a document locally it doesn't transfer the background colour. :woman_shrugging: Maybe my Linux is just not doing that.