Openfoodnetwork: Email copy/paste bug

[sseerrggii]

We know that this commit was done to avoid spam, but it only works well for people who use email clients. Although in many cases copy/paste is used and in that case it doesn't work.

In the example I copy the producer email [email protected] and paste moc.rotaniliam@1nfo, click on the GIF to see it better.

Severity

S3 - quite a few users are impacted, this is a basic behavior, but there is a workaround (retype email).

[lin-d-hop]

@oeoeaio @mkllnk @Matt-Yorkley @enricostano
Is everyone happy for this to be changed?
I understand the design is to stop trolling so if anyone has an alternative suggestion please do comment here.

I'd like to assign to someone in the UK as it is a UX annoyance.

[oeoeaio]

I am happy to change it. Spam filtering is pretty sophisticated these days, and the fact copying doesn't actually work is a problem.

[mkllnk]

I agree. This is actually really cool. It basically means that we won the war against spam. :-)

[oeoeaio]

Ok, there is a confusing set of issues related to this: #1200 (and associated PR #1368). #1840 (and associated PR #1909). As far as I can tell #1909 is essentially doing to the opposite of #1368.

I think we want word wrapping, but we need to stop using the mailto directive first, so that we don't get the issue recorded by #1200.

That would involve removing this file: app/assets/javascripts/darkswarm/directives/mailto.js.coffee
and any use of the directive (grep for mailto shows me 10 places where it is used). This means dropping the mailto: true and also any .reverse calls.

[sauloperez]

Agree and thank you for this work @oeoeaio

[RachL]

Hmm I definitely understand this is annoying, but it was clearly designed this way. So here we are again in a case where this is not a bug. I'm downgrading this as s4 for now and let's see if this can be a good first issue?

[mkllnk]

I don't think it's a good first issue because of all the connected issues and pull requests. There is a lot to consider here.

[RachL]

ok thx @mkllnk I'm leaving it has this then for now. And let's see if it's something that needs to be moved to discourse.

[Erioldoesdesign]

Definitely agreed this is not very nice for users. I understand it was designed that way but it's very unaccessible for anyone with cognitive impairments or using screen-readers are going to get very confused and distressed. Having a non-standard behaviour need too always have deep and serious conversations about what malicious intent this tries to avoid balanced against the well-meaning users that are negatively impacted.

Basically with this kind of behaviour we're putting the bad effect onto our well meaning users because we as OFN want to avoid spam...it's not very fair.

Also not many people use native mail clients unless they are on mobile. Even then many people copy paste.