Openfoodnetwork: Confusing UX on Delete Properties

[Matt-Yorkley]

Update by Myriam 21.05.2018 to clarify what needs to be done.

Description

While editing the product, there is an option to view 'PRODUCT PROPERTIES' This then shows any properties that have been assigned to the product. To delete a property you MUST click on the bin icon to the right of the product. Clicking the 'x' beside the property name does not result in a permanent removal of the property.

Expected Behavior

This page would be much more clear and consistent with the rest of OFN if we simply stop the X appearing next to the property name. (See image, there is no X)

The extra click for 'Update' is still obviously a UX sub-optimality however the user is warned before leaving the page if they haven't clicked save which is a big improvement to the current situation.

Actual Behavior

See image, there is a confusing X

Steps to Reproduce

1. Go to "products", select one product and click "edit" then go to tab "product properties"
2. Try deleting a property using the X and/or the bin

Context

Was reported by uk user https://community.openfoodnetwork.org.uk/t/deleting-product-properties/194

Severity

S4

Your Environment

PC, Retested on French production, Chrome

Possible Fix

Remove the "X" on property label

[sineadfenton]

Product properties not deleting successfully

[sigmundpetersen]

In support of the suggestion :)

[myriamboure]

Ok I cleaned up this issue, it is ready to be picked. Maybe @rtrunkhill you would be up for that new issue now that you start to see how OFN works ;-) ?

[Matt-Yorkley]

I was going to try to help out @rtrunkhill with this dropdwon issue, but in UK production and my latest local version of master this page seems to be broken, so I'm not sure how to help. Maybe that's another issue!

[Matt-Yorkley]

For reference @rtrunkhill as per your quest for the missing views, this page is originally generated by the Spree gem, but we have some overrides for these views using Deface. The files in question can be found in the /app/overrides/spree/admin/product_properties/ folder.

[myriamboure]

I think @Matt-Yorkley you are connected as an admin that's why you see what you see and the properties are not proposed to you ;-) Connect as a regular user.

[Matt-Yorkley]

I still get this:

...which doesn't look right. The delete buttons are missing and the table headings are misaligned.

[Matt-Yorkley]

Also, whenever I try to save using the update button I get bounced out of admin to the home page. My console shows a 302 redirect happens just before going to the home page, because the browser is incorrectly being sent to /products/product-name (which doesn't exist) instead of /admin/products/product-name after saving... :frowning_face:

@myriamboure can you do a quick check to see if you get the same on OFN France? I'll open a separate issue for this if so.

[myriamboure]

@Matt-Yorkley you need to "update" with one property, then the page recharges and you see the "delete" button appearing :-) You are right that "description" is misaligned, would be great to fix at the same time if possible. I don't have the same issue of getting taken out to home page though.
https://www.useloom.com/share/57e5c8acc60e4adeabc78646f3dad264

[Matt-Yorkley]

I restarted my local rails server and now I can't replicate that issue either :see_no_evil: Maybe it's ok.

[myriamboure]

I don't understand your last comment @Matt-Yorkley I can replicate the error, if I click on the small x on the property label I have the impression it is deleted but when I save it is not, it reappears... what do you mean by "maybe it is ok"?

[Matt-Yorkley]

Sorry, I meant the second bug I encountered yesterday where it redirected to the home page after saving. It's not doing that now.

[anushreddy]

can i take a look at it?

[lin-d-hop]

Feel free to take a look and ask questions on Slack, Anush :-)

[HugsDaniel]

Anyone tackling this one at the moment ?

[sigmundpetersen]

No I think you can go ahead @HugsDaniel 👍