Openfoodnetwork: Need a manual hack for a front end translation...

[myriamboure]

From the begining in theFrench instance, we have useda manual hack to display the translation on the "end date" of an order cycle. At each upgrade we needto do it again, so we would like to solve the issue more sustainably.
Any idea how we can display the translated string? @mkllnk or @sigmundpetersen maybe?

[myriamboure]

The problem doens't happen on our staging server, so it's link to internationalisation configuration apparently, but we don't find yet the problem...

[mkllnk]

That translation is done by a plugin called momentjs-rails. Maybe check for differences in your application configuration application.yml. Or read the documentation of that plugin. There might be hints why it thinks it should display English.

[myriamboure]

Ping @gnollet :-)

[blancnic]

I think we need to add //= require moment/fr.js
https://github.com/derekprior/momentjs-rails

[blancnic]

@mkllnk : don't you thing we could include this in a configuration file or define a all.js.coffee by country? Actually, we have to modify the js file each time we upgrade....

[myriamboure]

Why is it working in staging then?
Is there the same issue in Norway @sigmundpetersen ? You only have a production instance, o you have to modify the js file each time you upgrade as well?

[mkllnk]

all.js.coffee has already locale specific data, the I18n object with translations. If we could load other locale-dependent js-libraries in a similar way, that would be good. I don't think we want to include every locale in every instance. The all.js file would become too big and would negatively impact the user experience.

[sigmundpetersen]

@myriamboure yes we have the same issue on the Norwegian instance

[gnollet]

Hi,
I add the line //= require moment/fr.js on all.js.coffee and rebuild the assets.

That's fix the issue but we must think to this on each time we want to update platform.

[mkllnk]

Are you deploying via git push?

You can put that into your deploy script .git/hooks/post-receive on the server. Something like:

echo '//= require moment/fr.js' >> "$CURRENT_PATH/app/assets/javascripts/darkswarm/all.js.coffee"

Just before the assets are rebuild. I'm not sure about the path. You need to check that. But it would do it automatically every time you deploy.

[gnollet]

@mkllnk I'm using ansible scripts
I will take a look on the script to see if I can insert this

Thanks

[mkllnk]

That git hook is installed by the Ansible scripts, but not executed. The approach above works only with git-push deploys. If you do Ansible, you will need an Ansible playbook that adds that line to your all.js file.

[enricostano]

We'll need this for spanish instance too. cc/ @sseerrggii

[myriamboure]

I think this is something I reported in some Slack comments with remaining translation issues @pacodelaluna but it doesn't seem so trivial... I assign you as it's about translation issues but feel free to comment if needed!

[myriamboure]

@jeronimo are the PR you are committing solving this as well ? Else @lin-d-hop does anyone work on it or should we see on our side with @pacodelaluna ?

[myriamboure]

@enricostano any idea how to solve this issue ? It's coming up again each time we do an upgrade, and it's a front end issue to even worse... @ltrls or @pacodelaluna if you have some minutes to find how to solve that it would be awesome :-) It's really annoying ! At the moment it's in english on the French production server...

[sigmundpetersen]

Same as this #1781 ?

[sauloperez]

Yes, it is. Removing that one to keep the discussion here.

[leandroalemao]

All,
Just opened a PR #1819 to try to fix this issue.
👍 😄
Tks
Lenadro.

[myriamboure]

You are awesome @leandroalemao :-)

[sauloperez]

Already merged