Openemr: Required: suggestions for PR template

Created on 24 Feb 2020  路  5Comments  路  Source: openemr/openemr

As discussed, we are adding the PR template and I need some suggestions from mentors before I proceed.

  1. A general PR template would include, Description and Fixes heading.
  2. We can add a checklist that the contributor needs to follow, like
    a. Reading some guidelines
    b. Ensuring Tests are passed
    c. Every commit is squashed unless individually required
    d. There is a proper commit message

Is there anything else we could add?

All 5 comments

hi @thesmallstar ,
I'd focus on:
A proper explanation of the PR
(otherwise, wouldn't add many other requirements since don't want to scare folks away from contributing; we've had some really nice code contributions that come in all sorts of crazy messed up git branches since git proficiency and coding skills are not always aligned :) ; and the nice thing about github PR's is we can just squash the whole mess into 1 commit when bring it in :) )

I also should of added. It's not that uncommon that we end up fixing PSR2 issues (causes a travis fail) after bring in a PR.

@bradymiller I guess a simple template will then work, on it.
Sorry for the delays, I have college exams on going :)

no prob. college exams take priority :)

Closed by #2991

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stephenwaite picture stephenwaite  路  4Comments

MatthewVita picture MatthewVita  路  5Comments

yashrajbothra picture yashrajbothra  路  3Comments

im-Amitto picture im-Amitto  路  4Comments

stu01509 picture stu01509  路  5Comments