Open-ps2-loader: OPL locks up when creating VMC if there is not enough free space on internal HDD

[yoshi314]

Issue checklist

Note: these are not necessarily requirements

• [x] I have checked existing OPL issues for duplicates and found none @ http://psx-scene.com/forums/official-open-ps2-loader-forum/ & https://github.com/ifcaro/Open-PS2-Loader/issues

Open PS2 loader version

latest git (as of yesterday) ; OPL/0.9.3+.1442-Beta-361883d

Open PS2 loader mode (USB, SMB, HDD)

HDD

Open PS2 type (Normal, Childproof, VMC, GSM, PS2RD)

VMC+GSM+PADEMU+HIRES

Issue description - Describe the problem you are having

When creating a new vmc with full +OPL partition, the program locks up.

Expected result

Error message.

How to reproduce the issue

Attempt creating a new standard 8mb vmc with full +OPL partition.

[J013k]

It may be dumb question...
but does previous versions (e.g. 1436) also have this problem?

Was there ever any "safety switch" to prevent this from happening?
I mean "There is not enough space for creating VMC?" or something similar?

[yoshi314]

i'll have to build an older release and try it out. I'll post result in a few days.

[J013k]

If you want an older build you can also check e.g:

• OPL 1377:
  https://www.psx-place.com/threads/open-ps2-loader-game-bug-reports.19401/page-40#post-206080.
• OPL 1387:
  https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-44#post-210344.
• OPL 1436:
  https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-47#post-225201.

Here is OPL 1443 with newlib:
https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-48#post-240445.

[ElPatas1]

@yoshi314, Please have you been able to test the problem with previous beta versions as
@jolek has suggested, or with OPL 0.9.3?

There is no message in the OPL like "There is not enough space in the device for creating VMC",
but if there is no space i think the program should not hang, just don't create the VMC, no?

I wonder if the same happens for example when wanting to install a game on the
internal HDD over the network using the HDLDump Helper GUI, and the
+OPL partition don't have enough free space.

The OPL freezes? or the OPL HDLDump server closes from the side of the OPL without
installing the game?

I've never had the HDD full or near to be full to test this kind of things.

Best regards.

[yoshi314]

not yet, but i will do a few tests today.

i have a 512MB +OPL partition, so it was rather easy to fill it 100% with files that are multiples of 8MB.

[ElPatas1]

If you can test it with older betas, with the latest beta r1486, and with the
stable OPL 0.9.3 it would be great.

Best regards.

[yoshi314]

it seems all of them lock up attempting to create vmc at 0%.

[yoshi314]

I'll retest with the latest git build as well.

[ElPatas1]

Thank you very much, you tried with the stable OPL 0.9.3?

Best regards.

[sp193]

From what I do remember, there was no check on the available space. It makes sense, but it has to be implemented individually for each device supported to be truly inclusive. Other than the UI itself, the drivers need to support the necessary functions.
Since our PFS driver was based on the Sony driver, it can be done for the HDD. But this might not be possible (yet) for USB disks and maybe SMB shares.