Open-ps2-loader: infinte loading in ETH game list, games arent listed

[carl0sjt]

Issue checklist

Note: these are not necessarily requirements

• [ ] I have checked existing OPL issues for duplicates and found none @ http://psx-scene.com/forums/official-open-ps2-loader-forum/ & https://github.com/ifcaro/Open-PS2-Loader/issues

Open PS2 loader version

41aeb0b and d6f855d

Open PS2 loader mode (USB, SMB, HDD)

SMB

Open PS2 type (Normal, Childproof, VMC, GSM, PS2RD)

PAD EMU

Issue description - Describe the problem you are having

After i activate ETH device, the loading icon keep spining forever

Expected result

Should work like caaeafb (also PAD EMU) and older

Actual result

Dont display ETH games. Here is a Wireshark log https://1drv.ms/u/s!AoIhkAIkEXiDnHiLrvlImDmhqgcD

How to reproduce the issue

try to list games from ETH device page

PS: 212 itens in DVD folder, including games.bin

[carl0sjt]

Here is a video https://youtu.be/J3aoV8McGSM

Problem is also present in 80b1340

[TnA-Plastic]

That's possibly due to not unhooking the SMB-Server's share!

Does it work again, after restarting the host of the share (not OPL itself)?

[carl0sjt]

Does it work again, after restarting the host of the share (not OPL itself)?
No. And rev1250 works all the times.

[sp193]

Is your Killzone ISO a good disc image? It seems to have gotten stuck while accessing it. The last 2048 bytes of data requested, looks like garbage. The LBA also seems very high (it's near the end of the disc image).
I've not touched the isofs device driver nor the SMB code in months.

[sp193]

In case it really was a problem, please try this: https://www.sendspace.com/file/9bf1mq

ISOFS: replaced use of a single lseek with multiple long seeks when necessary, to avoid overflows when files are located towards the end of the disc. This is an attempt to improve reliability of OPL when a 2+GB game is stored on a USB disk or SMB share and the game has the SYSTEM.CNF file past the 2GB mark.
Specially, I am referring to Killzone. Even if it has its files stored at the end of the disc, it should not be a problem.

[carl0sjt]

the SHA-1 [ 53AAD9CF5EF00ED3CA4989BC123BAF0228F3921C ] of my Killzone ISO matches redump https://imgur.com/a/zo7fEKT.

Tested OPNPS2LD-db5628c and at first it populated game list, then i deleted games.bin and it hang in Killzone iso again. I moved Killzone iso to de trash bin, refreshed list and games appeared. I've spotted 2 that still arent listed if they dont have IDs in theirs names. These are Syphon Filter - Logan's Shadow (USA) SCUS_975.84 and State of Emergency (USA) SLUS_202.14

So far these games have problems with "New" ISO name

-Killzone (USA)
-State of Emergency (USA)
-Syphon Filter - Logan's Shadow (USA)
-Shin Megami Tensei - Persona 3 FES (USA)

[sp193]

I have adjusted the code for isofs, so maybe it'll now work properly with games that have SYSTEM.CNF located at the end of the disc, beyond the 4GB mark? Please try this: https://www.sendspace.com/file/psy9g1

[carl0sjt]

Voilá.. and this fixed it. Those games appear as they should now. Thanks )