Open-event-server: Celery accesses SMTP configs before exporting event

[kushthedude]

Celery needs SMTP Configuration before exporting the event.

Actual Behaviour :

Without the SMTP configuration, the event export task fails and throws this error.

[2020-02-10 17:16:00,274: ERROR/ForkPoolWorker-2] SMTP & sendgrid have not been configured properly
NoneType: None

Expected :

Event Export should work without the SMTP Configuration too.

[iamareebjamal]

How is this an issue?

[kushthedude]

Why celery needs smtp config to export an event? Why is this not an issue ?

On Mon, 10 Feb, 2020, 17:30 Areeb Jamal, [e-mail] wrote:

Closed #6833 https://github.com/fossasia/open-event-server/issues/6833.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-server/issues/6833?email_source=notifications&email_token=AKQMTLXJYATGD6DEANKRPSDRCE6XNA5CNFSM4KSMTOD2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWQTI45Y#event-3022425719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLUZVEHS7PE3PLFM4H3RCE6XNANCNFSM4KSMTODQ
.

[iamareebjamal]

This error is thrown when send_mail function is used

[kushthedude]

This error is thrown when send_mail function is used

Wasnt this case handled in the https://github.com/fossasia/open-event-server/pull/6228 , So why celery again accesses SMTP while exporting ?

[mrsaicharan1]

@kushthedude What do you mean by before exporting an event? How do you exactly reproduce this?
if this happens after you click on export event,
https://github.com/fossasia/open-event-server/issues/6158#issuecomment-512733961

[kushthedude]

@kushthedude What do you mean by _before_ exporting an event? How do you exactly reproduce this?
if this happens after you click on export event,
#6158 (comment)

As soon as I click on export event, The loader appears and the celery throws this error.

[mrsaicharan1]

Well, in that case, this is not valid. An export event mail task is scheduled which accesses the send_mail function. Check app/api/exports.py

[kushthedude]

Well, in that case, this is not valid. An export event mail task is scheduled which accesses the send_mail function. Check app/api/exports.py

Agreed the task is scheduled, But the export task should also be successful. The export fails, hence this should be a valid issue

[mrsaicharan1]

Ok, In that case, you need to be clear while mentioning the issue. Change the description to Event Export fails when SMTP settings aren't configured properly. Also mention the expected behaviour

[kushthedude]

@iamareebjamal @mrsaicharan1 I digged deep into the issue and it is not happening due to the server rather the FE url being generated is http://127.0.0.1:5000/v1/http://127.0.0.1:5000/static/media/exports/13/zip/ZDlVMEJ4Y0/event13.zip. There is an extra server URL param before the actual export zip URL which is being added due to https://github.com/fossasia/open-event-frontend/blob/development/app/components/events/view/export/download-zip.js#L12 . I will fix this on FE.