Open-event-server: Make Users API follow proper json spec

[niranjan94]

• attribute names must be hyphen separated. should be is-verified instead of is_verified
• ~default sort should be ascending. (?sort=name). Currently it seems to be descending (spec)~
• Hybrid properties throw error in sorting.

The rest seem to work nice. Haven't tested relationships yet since we don't have any

[shubham-padia]

@niranjan94 Can you please recheck default sort should be ascending. (?sort=name). Currently it seems to be descending once, seems to be ascending for me.

[niranjan94]

Okay. Ignore my comment. It is in ascending. Me blind 😋

[shubham-padia]

There's also another bug, Hybrid properties throw error in sorting, looking into it.

[shubham-padia]

attribute names must be hyphen separated. should be is-verified instead of is_verified, how much of a blocker is this ? flask-rest-jsonapi doesn't play well with hyphens.

[niranjan94]

Hmm... Okay. This can be compensated for in client side. But just
curious... What issue does the lib have with hyphen separated attribute
names?

On Mon, May 29, 2017, 1:20 PM Shubham Padia [e-mail]
wrote:

attribute names must be hyphen separated. should be is-verified instead of
is_verified, how much of a blocker is this ? flask-rest-jsonapi doesn't
play well with hyphens.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-orga-server/issues/3682#issuecomment-304596466,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACSwFIZ4FdfPbtAcp2Klpya8d4EpZu8Nks5r-njVgaJpZM4Nos1O
.

[shubham-padia]

@niranjan94 As variables can't have hyphens, marshmallow provides http://marshmallow.readthedocs.io/en/latest/api_reference.html#module-marshmallow.fields, load_from and dump_to, but weirdly flask-rest-jsonapi doesn't respect them at some places. If I give a query with ?sort=created-at it interprets the sorting param as createdat and throws an error.

[niranjan94]

Hmm... Okay... Weird. Cool. This shouldn't be a big blocker. Can be
corrected in the client side pretty easily. Will confirm though.

On Mon, May 29, 2017, 1:42 PM Shubham Padia [e-mail]
wrote:

@niranjan94 https://github.com/niranjan94 As variables can't have
hyphens, marshmallow provides
http://marshmallow.readthedocs.io/en/latest/api_reference.html#module-marshmallow.fields,
load_from and dump_to, but weirdly flask-rest-jsonapi doesn't respect them
at some places. If I give a query with ?sort=created-at it interprets the
sorting param as createdat and throws an error.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-orga-server/issues/3682#issuecomment-304600787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACSwFNMVrznvfOnKR6UO3heo54mkV83fks5r-n38gaJpZM4Nos1O
.

[shubham-padia]

Closed via #3683