Open-event-server: Add all system images to system image settings

Created on 20 Aug 2016  路  21Comments  路  Source: fossasia/open-event-server

Currently a number of images do not show up in the settings at http://open-event-dev.herokuapp.com/admin/content/

Please add images like:

  • [x] Top left logo
  • [x] Speaker placeholder image
  • [x] Profile placeholder image
  • [x] Speaker placeholder icon image
  • [x] Profile placeholder icon image
  • [x] Any other images

Also add:

  • [x] A helper text detailing the required standard pixel width/height

The tasks to be completed in this issue are:

  • [x] Implement upload/view functionality for all the above mentioned images at /admin/content/
  • [x] Make sure the application references to the upload images throughout.
admin images

Most helpful comment

@shubham-padia good work with the progress. But there are a few things I noticed.

  1. [x] Top left logo is missing
  2. [x] The user placeholder displayed is too big and out of proportions

screenshot from 2016-11-08 18 06 41

  1. [x] The upload dialog box is not displaying the correct dimensions required for the profile placeholder image. The image is too large for a profile image placeholder.

screenshot from 2016-11-08 18 07 11

@amitkumarj441 yourself and @shubham-padia could collaborate on this together.

All 21 comments

@mariobehling I'm willing to take up this issue. Can I add these images?

@amitkumarj441 you can go ahead :)

@niranjan94 Thanks for your prompt response! Where I can initiate PRs for these images?

@amitkumarj441 over here https://github.com/fossasia/open-event-orga-server/pulls just like any other PR for this project.

@amitkumarj441 also, please see /admin/content/ (the system images tab) to know what is expected

Thanks @niranjan94 ! I'll soon initiate some PRs in content!

@amitkumarj441 what is the progress on this issue ?

Sorry @niranjan94 for late reply!

You haven't updated this issue, we already discussed about this issue.
Please update this issue, so that I can able to make some PRs!

@amitkumarj441 done. Please proceed.

@niranjan94 @mariobehling Can i work on this issue ?

I've roughly implemented the points

Implement upload/view functionality for all the above mentioned images at /admin/content/

and

Please add images like

I can start working on

Make sure the application references to the upload images throughout.

if i get a go ahead.
Thank You.

@shubham-padia yes. You can proceed.

@shubham-padia what's the progress on this issue ? :)

@niranjan94 #2516 has been merged, only testing on the point

Make sure the application references to the upload images throughout.

Remains to make sure there aren't any discrepancies .
A third eye would be helpful in testing that :smiley:

@niranjan94 Apologies for the delay! Please let me know if their is anything pending!

@shubham-padia good work with the progress. But there are a few things I noticed.

  1. [x] Top left logo is missing
  2. [x] The user placeholder displayed is too big and out of proportions

screenshot from 2016-11-08 18 06 41

  1. [x] The upload dialog box is not displaying the correct dimensions required for the profile placeholder image. The image is too large for a profile image placeholder.

screenshot from 2016-11-08 18 07 11

@amitkumarj441 yourself and @shubham-padia could collaborate on this together.

@niranjan94 about

Top left logo is missing

Is there a provision for providing the top left logo, because currently it is hardcoded as follows

screenshot from 2016-11-08 18-27-22

@shubham-padia you'll have to make it such that the user can upload a logo image ... The text that is there now is just temporary

@niranjan94 can you please update the status of this issue. I believe that discrepancies mentioned in https://github.com/fossasia/open-event-orga-server/issues/2308#issuecomment-259126378 have been solved in #2533 . Thanks !!

@shubham-padia Top left logo is missing is still unsolved

@niranjan94 Can we close this :smiley: ?

Yep. We can close this ! Good job ! :smile:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mariobehling picture mariobehling  路  3Comments

shubham-padia picture shubham-padia  路  4Comments

shubham-padia picture shubham-padia  路  4Comments

mariobehling picture mariobehling  路  4Comments

Masquerade0097 picture Masquerade0097  路  3Comments