Open-event-frontend: Add bottom margin to event tags in event card

Created on 20 Mar 2019  ·  20Comments  ·  Source: fossasia/open-event-frontend

Describe the bug

The tags in event cards shown on homepage are quite close to the bottom boundary of the card. It will be better to add a bottom margin.
Also in the responsive mode, the tags go out of cards.
To Reproduce
Steps to reproduce the behavior:

  1. Go to '/'
  2. See error

Expected behavior

There should be some gap between tags and bottom boundary of card
Screenshots

Screenshot from 2019-03-20 15-47-08

Screenshot from 2019-03-20 16-12-58

Additional context

I am working on it.

UUX bug codeheat enhancement project ui

Most helpful comment

@Anupam-dagar Actually leave it open, just ask @CosmicCoder96 to add a later label on it

All 20 comments

Wants to take this issue
@Anupam-dagar

@mohitm15 I already opnened a PR

@Anupam-dagar that's nice

@Anupam-dagar But this is not showing in my laptop .... even after checking the responsiveness. I attached a screen shot too.

when screen is resized
Screenshot from 2019-03-20 18-08-52

@Anupam-dagar @mohitm15
Reproduce-able in Iphone5/SE and custom 888x888 config
image

@Anupam-dagar isn't it duplicate of #279

I think this should be enhancement of PR #236

@kushthedude since #279 has been closed by the owner himself and the issue still persists so no, this isn't a duplicate

I think a PR has been merged for a issue of overflow of text in event card

On Sat, 23 Mar 2019 at 8:24 AM, Uddeshya Singh notifications@github.com
wrote:

@kushthedude https://github.com/kushthedude since #279
https://github.com/fossasia/open-event-frontend/issues/279 has been
closed by the owner himself and the issue still persists so no, this isn't
a duplicate


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-frontend/issues/2346#issuecomment-475833261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqDJrhZIvhbEjWLwzjW4iUdSBiPsxBnHks5vZZd-gaJpZM4b-8_D
.

@kushthedude the merge was not for the overflow of the hashtags, which the current issue points out

Cool😁

On Sat, 23 Mar 2019 at 11:18 AM, Uddeshya Singh notifications@github.com
wrote:

@kushthedude https://github.com/kushthedude the merge was not for the
overflow of the hashtags, which the current issue points out


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-frontend/issues/2346#issuecomment-475842025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqDJro8bwc_MbXKX1T7_R_v1C1ROFyCNks5vZcA9gaJpZM4b-8_D
.

@Anupam-dagar Are you still on this issue?

This issue needs to be closed by @cosmiccoder96

On Wed, 17 Apr 2019, 12:05 Mohit Maroliya, notifications@github.com wrote:

@Anupam-dagar https://github.com/Anupam-dagar Are you still on this
issue?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-frontend/issues/2346#issuecomment-483956267,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUMZLB90BVkJzTXEYndy_g3BALN1C9Jyks5vhsCngaJpZM4b-8_D
.

@Anupam-dagar Actually leave it open, just ask @CosmicCoder96 to add a later label on it

@uds5501 That sounds better.

may I work on this issue?

Go ahead and make sure to check if the issue still exists, as we have upgraded the semantic-ui version recently.

Capture

@kushthedude sir i have made changes by inspecting in padding and i worked even responsive but vendor.css isn't in the development branch.
can you please help me find where i should make this change in code. so that i can make a PR

vendor.css is the compiled file. Not the source file. You don't make changes in compiled code, it is autogenerated

is this issue is open. do i work on this ?

Was this page helpful?
0 / 5 - 0 ratings