Open-event-frontend: Modify side bar to hide tabs for missing data

Created on 10 Aug 2017  路  4Comments  路  Source: fossasia/open-event-frontend

I'm submitting a ... (check one with "x")

Current behavior:
screenshot from 2017-08-10 05-49-28

Expected behavior:
The tabs should be hidden if the data is not present.

enhancement

Most helpful comment

@CosmicCoder96 No, for the above event, sessionspeaker is enabled but there is no speaker data, also the ticket is enabled but there is no ticked data present.

All 4 comments

@geekyd @sumedh123 Isn't this a duplicate of https://github.com/fossasia/open-event-frontend/issues/589 ?

@CosmicCoder96 No, for the above event, sessionspeaker is enabled but there is no speaker data, also the ticket is enabled but there is no ticked data present.

@geekyd Can you elaborate what is needed in this issue? Because if we check by doing:

event.speakers

or other things like this, we ll end up making request to speakers. I tried to do that in my PR for #589 but niranjan told me to remove that. Please correct me if I am wrong and explain what is required here?

We need a better way to handle this one option is to make all requests in the public route only. That way we wont be making duplicate requests.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mariobehling picture mariobehling  路  5Comments

mariobehling picture mariobehling  路  7Comments

codedsun picture codedsun  路  4Comments

hpdang picture hpdang  路  5Comments

anu-007 picture anu-007  路  6Comments