Open-event-droidgen: Add notifications in the application
Actual Behaviour
The API supports notifications but it is not implemented in the app.
Expected Behaviour
It should be implemented.
Would you like to work on the issue?
Yes
dr0pdb
All 15 comments
@srv-twry it is good idea as there is a lot of information about notification in api
@mayank8318 @nikit19 what do you think
jindalAnuj
on 31 Jan 2018
Yes, i have already discussed with the mentor on this.
dr0pdb
on 31 Jan 2018
@srv-twry is there any other channel or medium where we can discuss our ideas instead of issues tracker
jindalAnuj
on 31 Jan 2018
Yes, there is one. You can use gitter.
PS: My discussion took place in the orga app, where i created this issue even though it was supposed to be here.
dr0pdb
on 31 Jan 2018
Can you explain what would be there in the notification?
@srv-twry
For which activities you are doing?
shivaraju07
on 31 Jan 2018
Are you creating push notification?
shivaraju07
on 31 Jan 2018
No, it's not a push notification. The notifications will be fetched from the API.
Can you explain what would be there in the notification?
Please explore the API link that i have provided in this issue. I haven't explored it that much, i will do it later.
For which activities you are doing?
Most probably inside the MainActivity but open to suggestions.
dr0pdb
on 31 Jan 2018
I am thinking to create an email notification is it good?
shivaraju07
on 31 Jan 2018
Create an issue for it and we can discuss it there.
dr0pdb
on 31 Jan 2018
@iamareebjamal How would you suggest implementing this ?
I think we could add an notification icon on the action bar in the AboutFragment which would take the user to a fragment containing the recycler view with all the notifications.
dr0pdb
on 3 Feb 2018
It should be a separate menu in navigation drawer IMO
iamareebjamal
on 3 Feb 2018
Yeah, i will add that, but it's a standard to show atleast the notification icon with the count of notifications on the main screen.
dr0pdb
on 3 Feb 2018
AboutFragment is doing too much of a task IMO, so we'll see later what can be done but I'll recommend not to bloat an already bloated view
iamareebjamal
on 3 Feb 2018
@iamareebjamal Should i cache the notifications in the db or just treat it like a LiveFeed ?
dr0pdb
on 5 Feb 2018
Add it in db
iamareebjamal
on 5 Feb 2018
Related issues
gogeta95
路
7Comments
mayank8318
路
4Comments
mahikaw
路
8Comments
Shailesh351
路
6Comments
dr0pdb
路
7Comments
Most helpful comment
AboutFragment is doing too much of a task IMO, so we'll see later what can be done but I'll recommend not to bloat an already bloated view