Online-go.com: User profile popup not loading on first press

Created on 23 Nov 2020  路  5Comments  路  Source: online-go/online-go.com

When browsing my game history and clicking on a player I noticed the first time I press it's not loading properly:
image

Then if I click outside of the popup and press again it loads:
image

In the console I'm seeing these errors when this occurs:

Attempted to fetch invalid player name:  ...
invalid player name

Most helpful comment

I'm working on fixing it now.

All 5 comments

I half fixed it a while ago, previously someone took the name ... and it would actually take you to their profile instead of giving you the error message haha

I'm working on fixing it now.

@BHydden Can you point me to the commit where you did the half fix? In my PR I just disabled fetching by username if username is ... but I want to make sure that's a safe thing to do.

No commit, I just found the user with that name and changed his username to break the link haha

In my PR I just disabled fetching by username if username is ... but I want to make sure that's a safe thing to do.

that's technically a legal username, if someone should choose it again then they would have a very negative experience, perhaps the easiest solution is for @anoek to add that username to the disallowed list?

Was this page helpful?
0 / 5 - 0 ratings