Oni: Cmd + clicking a link should open the URL in the browser
This is a quite small improvement, but would allow to:
- Go to a linked issue
- Go to a piece of documentation (best example https://github.com/onivim/oni/blob/master/.oni/config.js#L3)
We could mimick the behavior of VSCode and:
- Coloring the link in an "active" color (link blue?) when hovering it with Cmd pressed
- Display a tooltip stating "Cmd + Click to follow the link" or something like that when hovering it without holding Cmd
I guess the key should be configurable so that it works on all platforms
rgehan
👍1
>All comments
This would go great with our integrated browser scenario (ie, #1699 )!
The language server protocol has a textDocument/documentLink request - this would be a good way to get / highlighting the links. I like the idea of using command+click to jump to the link, and also using the hover to show text so that the gesture is discoverable.
It seems like it would make sense to ensure this is consistent with our go-to definition gesture too.
bryphe
on 10 Mar 2018
👍2
Was this page helpful?
0 / 5 - 0 ratings
Related issues
badosu
路
3Comments
rgehan
路
3Comments
zxiest
路
3Comments
Canop
路
3Comments
LucianBuzzo
路
3Comments
Most helpful comment
This would go great with our integrated browser scenario (ie, #1699 )!
The language server protocol has a
textDocument/documentLinkrequest - this would be a good way to get / highlighting the links. I like the idea of usingcommand+clickto jump to the link, and also using the hover to show text so that the gesture is discoverable.It seems like it would make sense to ensure this is consistent with our go-to definition gesture too.