Oni: [Question] Keybinding to close pop up menus?

[nwaywood]

I didn't say this with the last issue I submitted but I want to say thank you for all the work you have put into this project! I am often switching between Atom and Neovim/Tmux and the potential of Oni is amazing!

The issue

By default, you can close the pop up menus (<m-p> and <m-s-p>) using <esc> or <C-c>. But I am trying to add a binding to close them with <C-g> because thats what I am used to from my dark days when I used emacs.

I have tried:

noremap <C-g> :call OniCommand('menu.close')<cr>

but it doesn't seem to do anything. Is this the right keybinding to be using? Or is there another keybinding that isn't documented?

[bryphe]

I didn't say this with the last issue I submitted but I want to say thank you for all the work you have put into this project! I am often switching between Atom and Neovim/Tmux and the potential of Oni is amazing!

Cheers, thanks a lot for the kind words 😄 Much appreciated!

Is this the right keybinding to be using? Or is there another keybinding that isn't documented?

Thanks for all the detail you put in here. It looks like there is an issue today where the input isn't passed to our neovim layer while the <m-p>/<m-s-p> menus are open.

In the meantime, you could add this in your config.js:

oni.input.bind("<c-g>", "menu.close")

In the activate section - that should achieve what you need.

[nwaywood]

Thanks, setting it in config.js works :)

I originally moved from setting keybindings in config.js to setting them in my init.vim because a lot of my bindings use <Space> (my leader key in vim) and binding with <Space> don't seem to work in config.js. I assume this is a known issue though?

[bryphe]

Thanks, setting it in config.js works :)

Awesome!

I originally moved from setting keybindings in config.js to setting them in my init.vim because a lot of my bindings use (my leader key in vim) and binding with don't seem to work in config.js. I assume this is a known issue though?

Ah yes - I'm not sure it's explicitly tracked though. Interestingly, using an explicit 'space' character works, for example: oni.input.bind("<c- >", () => { alert("hi") }), but that's not great and <space> should work. I logged #1300 to track this.

Unfortunately, it's also blocked by #1055 - we don't support 'chorded' bindings today (like <space>g, jk, etc).

[nwaywood]

Good to know, I'll keep on eye on those issues. Thanks