Oni: Scalable units are not based on fontSize

[badosu]

This might be a good or bad thing, but I noticed this when I upgraded Oni on a machine that I use with a Hi-DPI display, the OS font sizes are usually small so that was my motivation to make the status and tab bar scalable.

With font size 24px:

With font size 48px:

Examples chosen for emphasis (and not on the aforementioned display).

So, it seems they are inheriting the base font size from somewhere else than fontSize. That is fine by me, but breaks the purpose of why I developed the scalability for these elements.

If scaling with fontSize is not desirable perhaps we can at least offer configuration for the base font size these elements inherit from?

Statusbar font size is already configurable via statusbar.fontSize. If a respective one can be added for tabs then this is a non-issue, and the base font size configuration (or inheriting from editor font size) suggestions can be ignored.

Let me know your thoughts.

[CrossR]

To my knowledge there is as follows:

• Editor Font Size
• Status Bar Font Size
• UI font size

The last one seems to affect both tabs and the status bar, which I think covers what you want? Changing just "ui.fontSize" : "48px" made both my tab bar and status bar fonts huge.

Does that help?

Feels like as we add more and more config options, Oni is more and more in need of either a VS Code style search window through every setting and its default, or code completion style pop ups so you can just find the config options that way.

[badosu]

@CrossR Was not aware of ui fontSize, perhaps I should do my homework before putting issues.

Thank you very much @CrossR!

[bryphe]

Was not aware of ui fontSize, perhaps I should do my homework before putting issues.

Not your fault @badosu , it's confusing - I agree with @CrossR 's comment here:

Oni is more and more in need of either a VS Code style search window through every setting and its default, or code completion style pop ups so you can just find the config options that way.

Definitely need a way to make these more discoverable and intuitive! Glad that the ui.fontSize setting worked out in this case.