Ombi: Emby’s externally facing hostname generates wrong URL

[didusee]

Describe the bug
The URL generated by ombi to the related media on my server is generated wrongly. Clicking on the button "view in emby" links to a black site.

To Reproduce
what i put in ombi (settings > Externally Facing Hostname)
https:/myserveraddress.com/emby

the URL ombi generates and links to when clicking on "view in emby"
https://myserveraddress.com/emby/web/index.html#!/item/item.html?id=467687

Expected behavior
what the url is supposed to really look like in emby:
https://myserveraddress.com/emby/web/index.html#!/item?id=467687

**Desktop

• OS: Docker on unraid 6.8.2
  OS Architecture | X64, OS Description | Linux 4.19.98-Unraid #1 SMP Sun Feb 2 22:45:43 GMT 2020, Process Architecture | X64

**Ombi Version

• Ombi 3.0.4892,
• Emby 4.4.0.40

Additional context
I already deleted the OmbiExternal.db, which makes no difference at all and does not fix the problem.
There is a preview f the URL, ombi will generate under the formfield "Externally Facing Hostname".
This on is already messed up and shows the following that would not work either:
Current URL: "https://myserveraddress.com/emby/#!/item/item.html?id=1"

[ombi-bot]

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Have you looked at the wiki yet? https://github.com/tidusjar/ombi/wiki/
Before posting make sure you also read our FAQ.
Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Thanks!
Ombi Bot.

[Pyro2677]

Yes I am also having this issue.

[didusee]

I added a code change that might fix the problem to my understanding and would generate a valid URL to emby’s media
https://github.com/didusee/Ombi/commit/10bb22639bc880f59b7bf6b472f33f517accaf3e

please feel free to comment if you think, this is nonsense

[Pyro2677]

I have no idea what adding commit does but I hope old mate sees it and can quickly fix it for us on V3.

[tidusjar]

No that will not work, it will break for Jellyfin users. The problem is I am always changing this part of the code because the URL keeps changing :(

[Pyro2677]

Is there a way we can Manuall add the Serverid? Or have it so the user adds which ever one they have emby users click a button and Jellyfin users click another?

[tidusjar]

The server id is not the issue here?

[Pyro2677]

If I add “&serverId=***” it will take me to my server even with the current way it is. That’s why I suggested it. But if you take out the bit the other guy said it also works. So it would be too hard to have Emby and Jellyfin Seperate?

[Pyro2677]

You’re doing a great job with Ombi and I can’t believe I didn’t find it sooner and I can’t wait for V4.

[didusee]

The Server ID has no need for Emby Users. Here’s a test with results …
URL entered in Ombi’s inputfield under "settings > externally facing hostname":
https://myserveraddress.com

URLs generated by Ombi

remote
https://myserveraddress.com/web/index.html#!/item/item.html?id=123
Result: black screen

side-test with local URL
123.456.0.10:port/web/index.html#!/item/item.html?id=123
Result: black screen

same result when adding the Server ID to the generated URLs such as:
remote
https://myserveraddress.com/web/index.html#!/item/item.html?id=123&serverId=…
Result: black screen

side-test with local URL
123.456.0.10:port/web/index.html#!/item/item.html?id=123&serverId=…
Result: black screen

Working URLs

remote
https://myserveraddress.com/web/index.html#!/item?id=123
Result: correct media shown

local
123.456.0.10:port/web/index.html#!/item?id=123
Result: correct media shown

same result when adding the Server ID to the URL
remote
https://myserveraddress.com/web/index.html#!/item?id=123&serverId=…
Result: correct media shown

local
123.456.0.10:port/web/index.html#!/item?id=123&serverId=…
Result: correct media shown

Hope, that helps

[tidusjar]

thanks @didusee i'll try and fix soon

[tidusjar]

This has been fixed in v4

[didusee]

Thank you very much! really looking forward to it and keep up the amazing work.
Highly appreciated! :)

[Pyro2677]

This has been fixed in v4

Is there a chance you can fix it in V3? I have tried to install V4 on my linux VM but it's not playing ball for some reason.

[pawndev]

Hi @Pyro2677
@tidusjar merged this fix in the develop branch (see #3477 )
I think we need to wait until the next release 🙂

[tidusjar]

This might not fix it according to #3476