Olive: When using new proxy generator half size proxy crops generated media

[alcomposer]

[itsmattkc]

I can't recreate this. Can you tell me more about the source material and the steps you're taking to create the proxy?

[alcomposer]

I am right clicking the media in the project panel. Then selecting proxy. The media is prores, (1024x1024 UV Test Image as video). Select half - or quarter size proxy size, let it render.

When I go into the proxy folder and view the media with VLC, or Olive the media is not resized, but cropped - as in the image above.

[alcomposer]

I think I tracked down the issue (On Linux, or on my machine anyway)

in ProxyGenerator:

        bool convert_pix_fmt = (output_streams.at(stream_index)->pix_fmt != input_streams.at(stream_index)->pix_fmt);

I added these two QDebugs:

        qInfo() << "Output stream: " << output_streams.at(stream_index)->pix_fmt;
        qInfo() << "Input stream: " << input_streams.at(stream_index)->pix_fmt;

Looks like pix_fmt is the same for both, while they should be different. When I hard-code true:

        if (true) {
            // create sws frame for pixel format conversion
            enc_frame = av_frame_alloc();
            enc_frame->width = output_streams.at(stream_index)->width;
            enc_frame->height = output_streams.at(stream_index)->height;
            enc_frame->format = output_streams.at(stream_index)->pix_fmt;
            av_frame_get_buffer(enc_frame, 0);

            // convert pixel format to format expected by the encoder
            qInfo() << "return slice size: " << sws_scale(sws_contexts.at(stream_index), dec_frame->data, dec_frame->linesize, 0, dec_frame->height, enc_frame->data, enc_frame->linesize);

            // set same pts as dec_frame
            enc_frame->pts = dec_frame->pts;
        }

Then it works:

[itsmattkc]

Ahh good sleuthing, this is indeed an oversight of mine. I wrote an "optimisation" to not use swscale if the pixel formats were the same, forgetting that swscale would still need to be used for size changes.

I think the best fix would be to add extra conditions to the if statement to check if the destination width and height are different in addition to just the pixel format. That way the optimization can still be used when possible.

[itsmattkc]

Should be fixed in 2ba093640170181479189fff181e2c5670be1a80, let me know if not

[alcomposer]

Fixed