Ohara: [Manager] Address various issues in metrics

Created on 27 May 2020  ·  7Comments  ·  Source: oharastream/ohara

  • [x] Tweak pipeline metrics update logic (#5183)

    • Metrics switch should defaults to off
    • The switch should control metrics visibility and starting/stopping API request
  • [x] Fix metrics not correctly handle error issue (#5209)

    • Stop displaying metrics loading message when the request is failed
    • Display the metrics fetch error in event log and snackbar
  • [x] Update metrics should not updating unrelated components
  • [x] Recover the metrics update mechanism from HTTP request errors (#5222)
QA v0.11.0

All 7 comments

/cc @oharastream/frontend The changes will go into 0.11

@vitojeng I've added two tasks to address metrics is not loaded issue you just reported :)

Specifically:

  • Stop displaying metrics loading message when the request is failed
  • Display the metrics fetch error in event log and snackbar

@konekoya That's awesome! Thanks for great support.

ping @konekoya 這個議題可以關閉了嗎?

@jackyoh 再等我一天... ^^

OK, 收到了。我沒注意到 QA 的部份

QA passed.

Was this page helpful?
0 / 5 - 0 ratings