Ohara: [Manager] Using a better way to check configurator is available

Created on 11 Nov 2019  路  6Comments  路  Source: oharastream/ohara

Since we depend on specific URL to check configurator is ready or not (/inspect/configurator)

It is hard (at least, for me) to find out that we have a breaking change that influences the checking logic.

I found a npm package could help us to check the (ip, port) is reachable or not:
is-port-reachable

const isPortReachable = require('is-port-reachable');

(async () => {
    console.log(await isPortReachable(80, {host: 'google.com'}));
    //=> true
})();

Should we apply this package to our code base?

related to #3251

v0.9.0

All 6 comments

/cc @wu87988622 @konekoya
How do you think about this?

Good call @saivirtue :)

Same author, but I don't know the differences. May worth a try since this one has more npm downloads :)
https://github.com/sindresorhus/get-port#readme

Same author, but I don't know the differences. May worth a try since this one has more npm downloads :)
https://github.com/sindresorhus/get-port#readme

This module seems for generating random port :)

This module seems for generating random port :)

Ooops, that's why the same author 馃槄

@saivirtue could we close this issue now :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chia7712 picture chia7712  路  3Comments

chia7712 picture chia7712  路  4Comments

HarryChiang143 picture HarryChiang143  路  5Comments

saivirtue picture saivirtue  路  5Comments

saivirtue picture saivirtue  路  3Comments