Ohara: The UI checkbox item of FTP-Sink-Connector should not send null

[HarryChiang143]

Describe the bug
The [write header] checkbox item of FTP-Sink-Connector will send null on default value.

To Reproduce
Steps to reproduce the behavior:

1. Create v0.7 configurator and manager
2. Gen nodes and workspace and pipeline
3. Add FTP-Sink-Connector and test connection
4. See error

Expected behavior
The UI checkbox item of FTP-Sink-Connector should not send null

Screenshots

Operation System (please complete the following information):
Backend OS & Version: CentOS 7.3
Frontend OS & Version: CentOS 7.3
Browser & Version : Google Chrome , 版本 75.0.3770.100 (正式版本) (64 位元)

[HarryChiang143]

Ping @wu87988622 @saivirtue

[konekoya]

Thanks for reporting :)

[chia7712]

@konekoya would you please give a conclusion?

[konekoya]

@konekoya would you please give a conclusion?

Sure, I will write down the frontend part! But the backend part would need @saivirtue's help as I don't know much about the backend change in this particular issue :)

Why this is happening

The default value of the __write header__ definition is null but since the valid values for this definition is a Boolean value which means the value should either be ture or false. But right now manager is not handling this and simply return the default null value back to the backend, therefore, the error

Conclusion

As the metadata has provided needed information for UI. If a default value cannot be handled in the frontend (e.g. null). UI should return a valid value instead of values like null

This issue is affected in both 0.7 and the master. So the fix will go into these two branches

/cc RM @wu87988622 @chia7712 @saivirtue @HarryChiang143

I've filed another issue to tackle this #2501

[konekoya]

@HarryChiang143 this was fixed in #2501. I will update this thread once 0.7.1 is released