Ohara: Provide branch name in gradle.properties

Created on 15 Jul 2019  ·  8Comments  ·  Source: oharastream/ohara

More and more situations need to know the branch name, we should append a branch property to reduce the chance of hard-code branch name.

  • [x] Provide branch name in gradle.properties(#1883)
  • [x] Add branch name into InfoApi(#1913)
v0.7.0

All 8 comments

/cc @oharastream/developer

+1

@konekoya , @wu87988622

I found there are some files have hard-code version value:

  • ohara-manager/client/cypress/api/api.test.js
  • ohara-manager/client/cypress/support/commands.js

I think these should be read the version value from gradle.properties in the future.
Is this possible?

@vitojeng Could you add the new field "branch" to our ConfiguratorVersion? Also, update the docs for info APIs.

@vitojeng Could you add the new field "branch" to our ConfiguratorVersion? Also, update the docs for info APIs.

Sure, will do.

I think these should be read the version value from gradle.properties in the future.
Is this possible?

Yes, I think it's possible. I'll file a new issue to work on this :)

Great! Thanks @konekoya!

Tasks are done.

Was this page helpful?
0 / 5 - 0 ratings