Notebook: Dotted line of the ruler extension intersects the letters

[axil]

The latest notebook version that works correctly is 4.2.3:

I traced back the issue to the questionable codemirror bugfix https://github.com/codemirror/CodeMirror/issues/4042

I also provided a patch there.

But codemirror author believes that that the issue is on the jupyter side and suggests a solution there.

[rgbkrk]

Have you reported this to the ruler extension developer?

[axil]

@jcb91 - I think you're the right person to consider this?

[jcb91]

@axil I'll do :wink:. From your extensive detective work detailed on https://github.com/codemirror/CodeMirror/issues/4042, and as you suggest, CodeMirror dev seems to think that jupyter is not using CodeMirror's expected/required padding arrangement, which separates horizontal and vertical padding into separate elements. Since the nbextension doesn't add any CSS, it isn't the cause, and it would make sense to fix it in notebook here. I could presumably add CSS overrides to the extension as a temporary hotfix though...

[axil]

@jcb91 I would be happy with any solution that works and would be 'official'. As for myself I can make a hotfix in a couple of ways but I declared to my students that any decent editor has this feature (ruler) and the next day I found out that in jupyter (which is one of the editors that we use) this feature is currently hardly usable. I wouldn't like to advise them to make a manual patch in a python lib. :)

[jcb91]

I declared to my students that any decent editor has this feature

:rofl:

Ok, well, the best way seems like a PR to notebook, I guess, but equally, you can slap one onto ipython-contrib/jupyter_contrib_nbextensions, which _may_ get a patch release sooner...

[axil]

@jcb91 If that emoji meant irony, here's a list of python editors which support vertical guidelines:
spyder, pycharm, sublime, eclipse, vim, emacs, visual studio, mechanical typewriter, etc

[jcb91]

@axil apologies, reading that back, it wasn't very clear what I meant, but I very much agree that having a ruler is a basic feature of any decent editor. The intention was to convey laughter at the absurdity of not having a functioning ruler, but yeah, I should have used some actual words, rather than just an ambiguous face! I'll have a stab at an override for the extension now...

[jcb91]

ok, PRs for notebook & nbextension submitted...

[gnestor]

Notebook 5.2.0rc1 is available on PyPI so please give it a try and confirm that this is resolved 👍:

pip install notebook --pre --upgrade

[axil]

Yes, working as expected! That was fast! Thanks!