Nodejs.dev: Review the prettierrc and adapt "best practice"

[LaRuaNa]

We realised in a PR that the prettier config doesn't contain the "best practice". It needs to be reviewed and updated.

[mbj36]

@MylesBorins @keywordnew @amiller-gh need to discuss this asap as this can lead to conflicts in PR. we have already pinged interested people and definitely don't want people to solve conflicts as they land a PR.

[keywordnew]

We can allocate time in the next Website Redesign sync to discuss and find early consensus.

Or at least enough consensus to have initial answers to the most common configs. Much of the Prettier config will be down to preference :)

[ahmadawais]

I have a PR down in #90 and would love to take part and collaborate on this one. Shouldn't be a big issue. Also would love to create auto formatting after commit so everyone stays consistent with the standard even with different preference inside their editor of choice.

Peace! 👌

[LaRuaNa]

97

[jonchurch]

Here are prettierrc options for reference.

[LaRuaNa]

I'll open a PR in which I'll experiment with prettier based on tslint airbnb config

[sagirk]

As agreed in today's meeting, it's recommended to include the default settings too in the prettier config to explicitly state the project's choices.

The existing config remains as is, with the exception of jsxBracketSameLine which is to be turned off. ~I'm opening a new PR for this~ Done through https://github.com/nodejs/nodejs.dev/pull/153 ~and https://github.com/nodejs/nodejs.dev/pull/155~.

@LaRuaNa will take care of investigating tslint<->prettier integration on a separate PR and re-running #97.