Nodebb: Support for Sass

Created on 12 Aug 2017  Â·  12Comments  Â·  Source: NodeBB/NodeBB

I saw the previous issue (#3737) about it and saw that support for sass would be considered when bootstrap 4 hits beta.

That has now happened, so I'd like to make a request for this again.

In a perfect world, I'd ask for the ability for theme devs to choose their own framework to use (I personally love iota-CSS and would prefer to use it over bootstrap 4) but I'm not sure how tied in bootstrap is to everything.

request for comments

Most helpful comment

It would make everything easier if the CSS framework was tied to the theme and only the theme, but supporting plugins makes things more difficult.

If we want to go that way, we could deprecate using bootstrap entirely and load it when needed.

All 12 comments

@axynos Unfortunately bootstrap is tied in to too many things in NodeBB. Not easy to remove the dependency.

It is not impossible, but as @pichalite says, it is _not easy_.

@pitaj @yariplus perhaps one of you can investigate the feasibility of doing SASS... if the writing is truly on the wall for LESS.

It would make everything easier if the CSS framework was tied to the theme and only the theme, but supporting plugins makes things more difficult.

If we want to go that way, we could deprecate using bootstrap entirely and load it when needed.

Any update on this?
Considering of using NodeBB and interested in designing a theme using Bootstrap 4.

@julianlam Any updates on this? Bootstrap 4 was released in January. If usage of bootstrap is not deprecated then can it at least be updated?

Bootstrap 4 is a huge breaking change, it would break all plugins.

Bootstrap 4 is a huge breaking change, it would break all plugins.

@pitaj Yes, it will be a huge task, therefore planning should have started way back ago when Bootstrap 4 development was announced. Migration or possibly decoupling from Bootstrap should have started long time ago.

Any update on this? If it is not going to be removed, is there at least any planned upgrade path to Bootstrap 4?

Not at present -- our focus now is on releasing 1.9.0 with proper GDPR support, at which time we'll tentatively take a look at BS4 afterwards.

In terms of upgrade path, we'd likely need plugins rewritten to use the proper bs4 components, though we'll likely still support LESS compilation so as to not break backwards compatibility.

two years later, still no plans for bootstrap 4?

We do, actually!

We have a development branch going that integrates webpack and BS4. It is not anywhere near production ready and breaks almost everything, but alas, such is the price of progress...

On Sat, Jun 6, 2020, at 14:02, Philip T. wrote:

two years later, still no plans for bootstrap 4?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/NodeBB/NodeBB/issues/5874#issuecomment-640096983, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHBLAY4R2J7L4DCS2SDU6DRVKAB5ANCNFSM4DWVRKAQ.

breakage is expected, good to hear there's progress, I should have checked the active branches before posting

edit: I just stumbled upon a blogpost that talks more about the future plans https://blog.nodebb.org/looking-ahead-to-nodebb-v2-x/

Was this page helpful?
0 / 5 - 0 ratings