Node-red-contrib-homekit-bridged: Preparing for release 0.6.0

[Shaquu]

From a while we were adding more to dev branch. It's time to finally make it to release 0.6.0.

What I need from you is to test it AGAIN and report it as below.

• Linked Services - #41
• Mdns Configuration - #44
• Filter on topic
• NO_RESPONSE trigger - #48
• onIdentify - #54
• Backward Compatibility (MOST IMPORTANT)

Calling contributors but all are welcome to help!
@radokristof @crxporter @flic @radionoise @emilingerslev

PS. If I missed something then shout!

[radokristof]

No_Response should work on every valid characteristics?

[Shaquu]

I think it should work for all valid REQUIRED characteristics.

[crxporter]

I thought all was good then I noticed an issue with linked services and backwards compatibility. It appears all of the items that were in my system before updating are shown as "linked services" instead of "parent services" after updating to the dev branch. This doesn't seem to break anything - but it could cause confusion for people upgrading and wanting to add linked services...

I think pre-existing items should become parent services in 0.6.0

---

My other notes:

Starting from a working install of 0.5.1 I added in all of the examples from the wiki page and tested before updating to 0.6.0.

All items worked pre-update.

Backwards compatibility check: all items passed. No errors updating from 0.5.1 to dev branch.

Adding in NO_RESPONSE works on all required characteristics.

The example I made this morning of AirPurifier with all features and linked filter service works.

onIdentify works properly.

I'm not using mdns config so I can't test that - but it's not breaking anything.

Tested everything both on and off wifi (through apple tv hub) - no issues.

[crxporter]

Another interesting thing happening - deleting items from node red used to make them disappear immediately from the Home app.

This is not happening on 0.6.0 - seems to now be required to restart node-red for deleted items to be removed from the Home app.

[radokristof]

@crxporter In my opinion this should be the next priority, to work out somehow so that we don't have to restart node-red every time, just deploy to detect changes (add items, delete items, change items...).

[crxporter]

Generally if you add an item just once and hit "deploy modified nodes" things will work just fine without restart. As long as you don't hit "deploy" when the homekit nodes have been modified everything is fine and dandy.

Adding new items works fine without a node-red restart. Just don't run a full deploy.

Even deleting used to work without a restart of node-red... I just noticed today with 0.6.0 that it's not working properly.

[Shaquu]

Thanks for comments :)

So one by one.

1. Services should be default isParent set to true. It's strange that you have it set to Linked Service at default... Hmm. Are you sure you were testing last dev? I will check.
2. Fixing bugs correlated with need to restart node-red to make it work will be a main feature of next release (0.7.0). I really hate those bugs ;/
3. MDNS looks like not working. Got to fix it...

[flic]

Sorry I'm a bit late! Filter on topic works fine on the dev-branch.

[Shaquu]

@flic thanks for confirmation!

@crxporter please check newest dev for fix for default value Parent when moving to version 0.6 - should now work. Backward compatibility is highest priority.

[crxporter]

Off to install the 0.5 and run the update again... Stay tuned.

[crxporter]

LGTM - 0.5 nodes default to parent service in 0.6.

Just missing the NO_RESPONSE from @radionoise now, right? It's still working the "old way" before his new PR.

[Shaquu]

Yes, his PR need changes in readme so people know about his feature.

Wiadomość napisana przez crxporter [e-mail] w dniu 10.03.2019, o godz. 21:31:

LGTM - 0.5 nodes default to parent service in 0.6.

Just missing the NO_RESPONSE from @radionoise now, right? It's still working the "old way" before his new PR.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Shaquu]

Last checks guys!
I am planning to make a release tomorrow evening so we can head to more important stuff like bugs...
I hope nothing brakes :|

[crxporter]

Just updated to node-red 0.20.0 and installed a fresh dev branch.

I updated a different node through the palette manager and for some reason I was put back on 0.5.1 - but replacing the folder again got me right back to "everything looks good"

No new problems here on 0.6.0 or node-red 0.20.0.

[radokristof]

@Shaquu are you planing to push 0.6 to master today?

[Shaquu]

@radokristof I would like to do it but we need to retest Linked/Parent Services again due to changes in #41
So if you have time then please test it (mainly backward compatibility).
@crxporter are you there?

PS. So I assume it will happen tomorrow if you help me ;)

[crxporter]

No new errors here. Upgrading / downgrading / upgrading leaves things a bit confused but adding new stuff works as expected. 0.5 services load in properly so backwards compatibility is still good.

I'm sure users will find something else but hey- that's what 0.6.1 is for, right?!

Tested on node-red 0.20.1.

[crxporter]

PS - I'll be adding a comment on my openhab post about this plugin once 0.6 is released so that those users know to come use linked services. I know there's several people watching that thread more closely than anything over here...

[Shaquu]

Okay working on the merge. Thank you all!

[Shaquu]

We are online!