Nixpkgs: fetchurl/fetchzip fails based on file extension?

[deliciouslytyped]

with import <nixpkgs> {};
stdenv.mkDerivation {
   name = "test";
   src = fetchzip {
      name = "cs2d.zip";
      url = "http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266";
      sha256 = "1g66635m8zfsxdmg95c1xz72s6pam9w1myrjwk4dnw697dhpir1p";
      };
}

fails with

trying http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266
unpacking source archive /build/get.php?get=cs2d_1008_win.zip&p=1&cid=1266
do not know how to unpack source archive /build/get.php?get=cs2d_1008_win.zip&p=1&cid=1266

Also my understanding is maybe the result should be renamed to the name attribute?

[deliciouslytyped]

The main culprit seems to be https://github.com/NixOS/nixpkgs/blob/f81ddbf8e7889e63496d3263f4ce28e5f9c79269/pkgs/tools/archivers/unzip/setup-hook.sh#L3
which is called by https://github.com/NixOS/nixpkgs/blob/28a95c4f7f1c46399e8938d7f3e08169cda61191/pkgs/stdenv/generic/setup.sh#L845

If we want to keep this behaviour maybe fetchurl should get some additional phases?

[deliciouslytyped]

Alternatively the culprit is https://github.com/NixOS/nixpkgs/blob/ad4f7dd90e098f344114bc8f54ab5025233f1ffe/pkgs/build-support/fetchzip/default.nix#L30

I thought passing curlOpts to fetchzip, which passes it through to fetchurl - might work but the -o option is already taken when downloadToTemp ( https://github.com/NixOS/nixpkgs/blob/ad4f7dd90e098f344114bc8f54ab5025233f1ffe/pkgs/build-support/fetchzip/default.nix#L22 ) is true.

[deliciouslytyped]

TODO: how is the name argument of fetchzip even used, and how is it expected to be used?
It only seems to get passed through to fetchurl.

[Luis-Hebendanz]

@Mic92 Still broken also broken in stable :(

[Mic92]

workaround atm would be:

with import <nixpkgs> {};
stdenv.mkDerivation {
   name = "test";
   src = fetchzip {
      name = "cs2d.zip";
-      url = "http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266";
+      url = "http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266#cs2d.zip";
      sha256 = "1g66635m8zfsxdmg95c1xz72s6pam9w1myrjwk4dnw697dhpir1p";
      };
}

[Mic92]

or just:

with import <nixpkgs> {};
stdenv.mkDerivation {
   name = "test";
   src = fetchzip {
      name = "cs2d.zip";
-      url = "http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266";
+      url = "http://www.unrealsoftware.de/get.php?p=1&cid=1266&get=cs2d_1008_win.zip";
      sha256 = "1g66635m8zfsxdmg95c1xz72s6pam9w1myrjwk4dnw697dhpir1p";
      };
}

[deliciouslytyped]

@Mic92 Thanks, I hate it.
(no really, thanks though... facepalm)

[Mic92]

Even when downloadedToTemp is set, it might be still possible to fix the file extension:

https://github.com/NixOS/nixpkgs/blob/7a4a8e008988b64059e7b8f1ee5e30c0102a36e4/pkgs/build-support/fetchurl/builder.sh#L25

We just need to replace file with $(basename $out).

[brainrape]

Changing the file name to $(basename $out) would require putting the file extension in the package name, which is far from ideal. fetchzip et al are sometimes used to install packages which require no build steps, and the package name in this case is set to name-version as usual.

The unpacker should not check the extension at all. It should simply try unpacking with all available archivers, or consult file or a similar tool that parses file headers.

[stale[bot]]

I marked this as stale due to inactivity. → More info

[Luis-Hebendanz]

Has this been fixed?