Nivo: v0.66.0: npm/yarn package has wrong peerDependencies

Created on 1 Dec 2020  路  3Comments  路  Source: plouc/nivo

Describe/explain the bug

v0.66.0: npm/yarn package has wrong peerDependencies

To Reproduce

Steps to reproduce the behavior:

  1. Make an empty directory, and walk into the directory
  2. Run command:
    shell npm install --save [email protected] [email protected] @nivo/[email protected] @nivo/[email protected] @nivo/[email protected]
    or
    shell yarn add [email protected] [email protected] @nivo/[email protected] @nivo/[email protected] @nivo/[email protected]
  3. See warnings about peer dependencies like following:

warning " > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning "@nivo/line > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning "@nivo/line > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning "@nivo/line > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning "@nivo/line > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning "@nivo/line > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning "@nivo/line > @nivo/[email protected]" has incorrect peer dependency "@nivo/[email protected]".
warning " > @nivo/[email protected]" has unmet peer dependency "@nivo/[email protected]".

Expected behavior

Not complaining about peer dependencies since it correctly set to 0.66.0 in 1f6cb2c933d1a319f223ea5509f12e17a952addc

Screenshots
npm:
image

yarn:
image

Desktop:

  • OS: Windows
  • Browser: -
  • Version: -

Additional context

As 1f6cb2c933d1a319f223ea5509f12e17a952addc, peerDependencies are correctly set to v0.66.0. But, if you check the published package, it says something different.

For example: @nivo/line package

When you see package.json file in the package, it ends with following lines:

  "peerDependencies": {
    "@nivo/core": "0.65.0",
    "prop-types": ">= 15.5.10 < 16.0.0",
    "react": ">= 16.8.4 < 18.0.0"
  },
  "publishConfig": {
    "access": "public"
  },
  "gitHead": "1f6cb2c933d1a319f223ea5509f12e17a952addc"
}

and it's different from https://github.com/plouc/nivo/commit/1f6cb2c933d1a319f223ea5509f12e17a952addc#diff-8907db74c10b8063551067aff4f70d63a219f7fc6142249ff288556cb05ab2adR45

Most helpful comment

Thanks for reporting, we thought we were bumping them in the correct lifecycle, but we will need to adjust the scripts.

All 3 comments

Thanks for reporting, we thought we were bumping them in the correct lifecycle, but we will need to adjust the scripts.

Oh PR merged, thanks for the fix. Looking forward the next release.

Just checked https://github.com/plouc/nivo/pull/1317#issuecomment-742517603. Thanks for the fix!

Was this page helpful?
0 / 5 - 0 ratings