Ngx-quill: setDisabledState of ControlValueAccessor

Created on 12 Nov 2018  ·  5Comments  ·  Source: KillerCodeMonkey/ngx-quill

Please, add implementation of 'setDisabledState' method of ControlValueAccessor. Method implementation is quite simple, you just need to call appropriate method of quill editor instance either .enable() or .disable, based on what you have got in 'setDisabledState' method.
Because for now there is no straightforward way to disable editor.
In my case I want to disable whole form and I need to get all instances of quill editor through the '@ViewChildred' and manually call .disable() method for each instance.
It is also will be helpful if you can add 'disabled' attribute to the host element to have a simple way to apply styles.
Thanks.

Most helpful comment

check v4.1.0

Example is also added to the example repo 👍

All 5 comments

My component has a readonly Flag, but i will Check this in the next day.

If You can Not wait, send me a pr :)

Am Mo., 12. Nov. 2018, 09:43 hat swymmwys notifications@github.com
geschrieben:

Please, add implementation of 'setDisabledState' method of
ControlValueAccessor. Method implementation is quite simple, you just need
to call appropriate method of quill editor instance either .enable() or
.disable, based on what you have got in 'setDisabledState' method.
Because for now there is no straightforward way to disable editor.
In my case I want to disable whole form and for now I need to get all
instances of quill editor through the '@ViewChildred' and manually call
.disable() method for each instance.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/KillerCodeMonkey/ngx-quill/issues/282, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACKOYHgNL9B91kRMC7aZXNieQQnulnCBks5uuTS-gaJpZM4YZMG0
.

@KillerCodeMonkey please, check out my PR.

I will Check it on thursday

Am Mo., 12. Nov. 2018, 21:07 hat swymmwys notifications@github.com
geschrieben:

@KillerCodeMonkey https://github.com/KillerCodeMonkey please, check out
my PR, please.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KillerCodeMonkey/ngx-quill/issues/282#issuecomment-438012065,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKOYPlmI6emB7OwL0nYmrwfENr_JiIMks5uudUQgaJpZM4YZMG0
.

merged #283

check v4.1.0

Example is also added to the example repo 👍

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vaags picture vaags  ·  6Comments

anshumandikshit picture anshumandikshit  ·  3Comments

Fzwael picture Fzwael  ·  3Comments

bolota picture bolota  ·  3Comments

anthonyinspace picture anthonyinspace  ·  3Comments