Ngx-quill: Angular 6 support

[PoiScript]

Will this package supports Angular 6 and rxjs 6? I'm trying to update my application now. :)

[KillerCodeMonkey]

it will, but when it is final ;)

[josepfdc]

No work in angular cli 6... please !!!! could you fix it !

Thank you !!!

[KillerCodeMonkey]

It would be nice if you would share a more specific description of the error... instead of a message without any content and multiple "!" ;)

[elias-garcia]

Hi! This is the error in Angular 6:

ERROR in ./node_modules/ngx-quill-editor/index.ts
Module build failed: Error: /Users/elias/Documents/agora-binaria/eduhostalaria/client/node_modules/ngx-quill-editor/index.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).
    at AngularCompilerPlugin.getCompiledFile (/Users/elias/Documents/agora-binaria/eduhostalaria/client/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:708:23)
    at plugin.done.then (/Users/elias/Documents/agora-binaria/eduhostalaria/client/node_modules/@ngtools/webpack/src/loader.js:41:31)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:182:7)

[bop10]

There is a problem when you try to update rxjs too (Angular 6 requires rxjs 6):

Package "ngx-quill" has an incompatible peer dependency to "rxjs" (requires "^5.5.2", would install "6.1.0").
Incompatible peer dependencies found. See above.

[KillerCodeMonkey]

feel free to test a beta-release 3.0.0-1 updated only the dependencies. i have to check if it is really working :)

[elias-garcia]

I will give it a try in a few minutes! 😄 @KillerCodeMonkey

[KillerCodeMonkey]

beta demo page released: https://killercodemonkey.github.io/ngx-quill-example/

maybe someone know why i get strange warning and error (but not failing) during tests:

DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead

Child process failed to process the request:  TypeError: Cannot read property 'externalModuleIndicator' of undefined
at Object.isExternalModule (/Users/bengtler/dev/ngx-quill/node_modules/typescript/lib/typescript.js:13733:21)
    at Object.getAllDependencies (/Users/bengtler/dev/ngx-quill/node_modules/typescript/lib/typescript.js:75788:46)
    at Object.getAllDependencies (/Users/bengtler/dev/ngx-quill/node_modules/typescript/lib/typescript.js:76133:80)
    at processEmit (/Users/bengtler/dev/ngx-quill/node_modules/awesome-typescript-loader/src/checker/runtime.ts:451:24)

ERROR in ./index.ts
Module build failed: TypeError: Cannot read property 'match' of undefined
 at Object.exports.fromSource (/Users/bengtler/dev/ngx-quill/node_modules/convert-source-map/index.js:114:19)
    at Object.exports.default (/Users/bengtler/dev/ngx-quill/node_modules/istanbul-instrumenter-loader/dist/index.js:17:54)

[KillerCodeMonkey]

3.0.0 released it is working for me, tested with latest angular cli (ng serve is working) build of --prod --aot runs without errors

[elias-garcia]

Also working for me, thanks a lot! 👍