Ngx-datatable: Sort doesn't work on the first click

[maxisam]

I'm submitting a ... (check one with "x")

[ x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
when click on column header at the very first time, the data in the table kinda moving around but not sort correctly.

after first click, everything works properly. (or not, sometime the first row is not really the first one like it should be.)

Expected behavior

should work at the first time

Reproduction of the problem

on demo page

Please tell us about your environment:
Win10/Chrome

• **Table version: latest
• Angular version: 2.0.x

Thank you for your great work !

[colinfang]

Thanks for the spot, I knew there is something weird with the sort. I had thought it was just slow responsiveness.

[amcdnl]

Fixed in latest release.

[maxisam]

ah.... it is kinda broken again. Check it on demo page

When you click it, it doesn't sort correctly. The first one is off.

And the asc and desc are kinda weird too.

in the begining:

1st click , it shows sort-asc, but the first one is off.

2nd click, it shows sort-desc but the whole list is asc

3rd click, it shows sort-asc, but the whole list is desc

When I said sort asc/desc, I was referring to the code out put not icon.

[maxisam]

Another interesting behavior is, if you try it on filter demo, sort it first and type something in the filter and the sorting will flip back to correct order.

[amcdnl]

Might be related to https://github.com/swimlane/angular2-data-table/blob/master/src/components/datatable.component.ts#L96 ...

[maxisam]

yeah, I was looking at that line too. But I think it is correct, because it flips back to correct order, which indicates the sorting function works correctly.

[scottmizo]

@amcdnl I think you are correct. It appears that the setter is causing sortRows to be called a second time when the column header cell is clicked.

[amcdnl]

Fixed in 2.0