News: Article images missing

Created on 18 Mar 2019  路  15Comments  路  Source: nextcloud/news

Some feeds use a image for their articles. With the current release and master this seems to be partially broken.

First feed http://rss.golem.de/rss.php?feed=ATOM1.0 no image at all which doesn't break the web-ui but causes some weird behavior in the android app. Maybe @David-Development can help :)

Checking the xml for this one I don't know where we ever got that article image from. There is no direct reference. :confused:

Second feed http://feeds2.feedburner.com/stadt-bremerhaven/dqXM has an ad-image in it's feed which gets displayed fine in the web-ui but the article image is missing. In the android app the ad-image will be used as article image.

This one has references to the article-image, even multiple, once for each common width :man_facepalming:

As a last working example I found http://www.heise.de/newsticker/heise-atom.xml which has a very clean xml file easy to read and works fine in web and android.

I don't know if we are capable of fixing this.

If you have other examples please provide the following:

  • feed url
  • screenshot if the behavior differs from my examples.
    Keep it short. And no "same" postings please.
0. Needs triage regression

Most helpful comment

Possibly unrelated the images of xkcd.com also don't get shown anymore as mentioned in #426 .
But for me this is a regression in 13.1.4. It worked until 13.1.2.

All 15 comments

Reddit RSS feeds also don't show any pictures anymore. This worked flawlessly in previous releases.

One example:

https://www.reddit.com/r/cats/.rss

Just add .rss to any Subreddit and you get a RSS feed from it.

Hello there,
The Brothers Brick -> http://feeds.feedburner.com/TheBrothersBrick
Space.com-> https://www.space.com/feeds/all
Likecool -> http://feeds.feedburner.com/likecool (see screenshot below, missing favicon and picture)
20190319_163851

used to display fine in app and browser version

That last feed works fine on my server, which probably means that these imports predate the XML fix in the latest release. As for the reddit images, there's no images in the feed.

There are images in almost all the news items in the Reddit feed I mentioned, they were all shown perfectly well in past versions of the News app. But indeed it is strange: Some images are shown, a lot aren't. Here is a screenshot of how it looks like:

image

Here is a working entry:

<entry><author><name>/u/rollsteelertide</name><uri>https://www.reddit.com/user/rollsteelertide</uri></author><category term="cats" label="r/cats"/><content type="html">&lt;table&gt; &lt;tr&gt;&lt;td&gt; &lt;a href=&quot;https://www.reddit.com/r/cats/comments/b3eekx/so_this_dudes_name_is_mr_carl_he_lives_in_our/&quot;&gt; &lt;img src=&quot;https://a.thumbs.redditmedia.com/7zYi5SnIma49n3t5n43yrN2EgFY0J6rJnoV8QU66FN4.jpg&quot; alt=&quot;So this dude鈥檚 name is Mr. Carl. He lives in our apartment complex, but has some behavioral issues with the other cats in his home. Apparently, he beats them up a lot. So, his owners let him come hang out at our house and he sleeps on our guest bed like a human. He loves the pillows!&quot; title=&quot;So this dude鈥檚 name is Mr. Carl. He lives in our apartment complex, but has some behavioral issues with the other cats in his home. Apparently, he beats them up a lot. So, his owners let him come hang out at our house and he sleeps on our guest bed like a human. He loves the pillows!&quot; /&gt; &lt;/a&gt; &lt;/td&gt;&lt;td&gt; &amp;#32; submitted by &amp;#32; &lt;a href=&quot;https://www.reddit.com/user/rollsteelertide&quot;&gt; /u/rollsteelertide &lt;/a&gt; &lt;br/&gt; &lt;span&gt;&lt;a href=&quot;https://i.redd.it/hpaf1dqr0bn21.jpg&quot;&gt;[link]&lt;/a&gt;&lt;/span&gt; &amp;#32; &lt;span&gt;&lt;a href=&quot;https://www.reddit.com/r/cats/comments/b3eekx/so_this_dudes_name_is_mr_carl_he_lives_in_our/&quot;&gt;[comments]&lt;/a&gt;&lt;/span&gt; &lt;/td&gt;&lt;/tr&gt;&lt;/table&gt;</content><id>t3_b3eekx</id><link href="https://www.reddit.com/r/cats/comments/b3eekx/so_this_dudes_name_is_mr_carl_he_lives_in_our/" /><updated>2019-03-20T16:54:36+00:00</updated><title>So this dude鈥檚 name is Mr. Carl. He lives in our apartment complex, but has some behavioral issues with the other cats in his home. Apparently, he beats them up a lot. So, his owners let him come hang out at our house and he sleeps on our guest bed like a human. He loves the pillows!</title></entry>

Here is a non-working one:

<entry><author><name>/u/nancyxxu</name><uri>https://www.reddit.com/user/nancyxxu</uri></author><category term="cats" label="r/cats"/><content type="html">&lt;table&gt; &lt;tr&gt;&lt;td&gt; &lt;a href=&quot;https://www.reddit.com/r/cats/comments/b3h29x/we_dont_fist_bump_we_head_bump/&quot;&gt; &lt;img src=&quot;https://b.thumbs.redditmedia.com/n3QMAU5s6SNF3VXpAo54zaJpKN-MrH64I0898Xf9xpA.jpg&quot; alt=&quot;We don't fist bump, we head bump.&quot; title=&quot;We don't fist bump, we head bump.&quot; /&gt; &lt;/a&gt; &lt;/td&gt;&lt;td&gt; &amp;#32; submitted by &amp;#32; &lt;a href=&quot;https://www.reddit.com/user/nancyxxu&quot;&gt; /u/nancyxxu &lt;/a&gt; &lt;br/&gt; &lt;span&gt;&lt;a href=&quot;https://i.redd.it/z3c8faq04cn21.jpg&quot;&gt;[link]&lt;/a&gt;&lt;/span&gt; &amp;#32; &lt;span&gt;&lt;a href=&quot;https://www.reddit.com/r/cats/comments/b3h29x/we_dont_fist_bump_we_head_bump/&quot;&gt;[comments]&lt;/a&gt;&lt;/span&gt; &lt;/td&gt;&lt;/tr&gt;&lt;/table&gt;</content><id>t3_b3h29x</id><link href="https://www.reddit.com/r/cats/comments/b3h29x/we_dont_fist_bump_we_head_bump/" /><updated>2019-03-20T20:34:34+00:00</updated><title>We don't fist bump, we head bump.</title></entry>

Golem.de:
There is this "Volltext-RSS-Feed inklusive Bilder und Videos" (fulltext feed with images and videos) for customers, so I cannot give you the feed-URL, but I'll attach a current Download.
The Screenshot shows, that there are tons of -tags, that are not present in the feed itself...

Screen Shot 2019-03-22 at 08 01 27

feed_fulltext_media_full-ATOM1.0.xml.txt

I noticed this because I'm reading a couple of web comics in my feed reader. It even seems to be occuring inconsitently within a single feed (talking about https://www.smbc-comics.com/comic/rss):

Displayed: For example the articles titled "Computer", "Whoopsie" or "Infallible"
Not displayed: "Heartbreak", "Living Wage", "Pucker Up"

<item>
  <title>Saturday Morning Breakfast Cereal - Heartbreak</title>
  <description>
  <a href="https://www.smbc-comics.com/comic/heartbreak">
  <img src="https://www.smbc-comics.com/comics/1552489520-20190313 (1).png" />
  <br />
  <br />
  Click here to go see the bonus panel!</a>
  <p>Hovertext:
  <br />
  The real asshole is the Renewed Hope Fairy. They do a good-cop bad-cop routine together.</p>
  <br />
  Today's News:
  <br />
  </description>
  <link>https://www.smbc-comics.com/comic/heartbreak</link>
  <author>[email protected]</author>
  <pubDate>Wed, 13 Mar 2019 11:05:13 -0400</pubDate>
  <guid>https://www.smbc-comics.com/comic/heartbreak</guid>
</item>
<item>
  <title>Saturday Morning Breakfast Cereal - Computer</title>
  <description>
  <a href="https://www.smbc-comics.com/comic/computer">
  <img src="https://www.smbc-comics.com/comics/1552399847-20190312.png" />
  <br />
  <br />
  Click here to go see the bonus panel!</a>
  <p>Hovertext:
  <br />
  Sadly, that burrito was filled with inhabited universes before God microwaved it.</p>
  <br />
  Today's News:
  <br />
  <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
  <p>Half of BAHFest MIT tickets are gone! 
  <a href="http://east.bahfest.com/" target="_blank">Buy soon, geekwads!</a></p></description>
  <link>https://www.smbc-comics.com/comic/computer</link>
  <author>[email protected]</author>
  <pubDate>Tue, 12 Mar 2019 10:03:32 -0400</pubDate>
  <guid>https://www.smbc-comics.com/comic/computer</guid>
</item>

Screen Shot 2019-03-24 at 10 36 42
Screen Shot 2019-03-24 at 10 37 23

To be clear: "Today's news" is the complete content shown for the second item. Previous behavior was to display the articles like shown for the first item.

Possibly unrelated the images of xkcd.com also don't get shown anymore as mentioned in #426 .
But for me this is a regression in 13.1.4. It worked until 13.1.2.

Seems to be fixed in 13.1.5

FYI: I thought it was not fixed, since for example XKCD feed was still not displaying images.
Then I tried their proposed ATOM feed and this one works, albeit without the favicon displayed beside the feed title in the feeds list...(it is present beside the RSS feed title in that same list)
Problem is that it is the first time I've seen a website proposing that choice...

For me the xkcd-rss feed works. Maybe the problem was that you expected the old (already fetched by news) items to show images? That does not happen because the feed is parsed and items get pushed to your DB. Only new Items will profit from new parser-features.

you are absolutely right! I unsubscribed from the rss version and re-subscribed, and here were the images.
Although now the favicon beside the feed title is gone for this one too...

So, I did the same manipulation with another feed, deleted and re-subscribe...
L'actu en patates RSS
images are not displayed, but the favicon beside the feed's title is gone
there is no visual indicataion replacing the missing main image, but the social network logos are replaced by the "broken image" icon.
Tell me if you need a screenshot, I have one ready.

I subscribed and can see the images. Can you create a new bug report with all the required data?
That would make it way easier to debug, thanks :)

All right :) I will wait a few days and see if the bug is still there, then if needed create a new issue

I confirm that the issue seems to be solved.
Thanks again and congrats!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bcutter picture bcutter  路  5Comments

criwe picture criwe  路  7Comments

rscmbbng picture rscmbbng  路  6Comments

Refhi picture Refhi  路  8Comments

hanzei picture hanzei  路  7Comments