here are a few minor bugs i've spotted (sorry for not filling the template) :
| issue 1 | issue 2 | issue 3 |
| :------------- | :----------: | -----------: |
| 
| 
| 
|
| the size of the notification bar | look closley on the time indicator | missing fullscreen icon when auto rotation is enabled |
and apart from all of this can you please tell me what is the difference between the share icon and the globe(earth?) icon (aren't they doing the same function?)
panacist
All 33 comments
the size of the notification bar
This is the old notification style. It will be replaced by the new one in #3178. You can test the APK there.
missing fullscreen icon when auto rotation is enabled
Intentional, because it will change orientation with the phone, so you don't need the button.
opusforlife2
on 7 Sep 2020
@opusforlife2
This is the old notification style. It will be replaced by the new one in #3178. You can test the APK there.
thank you i will test it as soon as possible
Intentional, because it will change orientation with the phone, so you don't need the button.
well i think it shouldn't be this way? i really though it's a bug at first and other users may have similar impression because it's an unusual feature
panacist
on 7 Sep 2020
The whole UI is new, and full of new things users will have to get used to with time. But what is the _problem_ you're facing with the button?
opusforlife2
on 7 Sep 2020
the size of the notification bar
Don't get me wrong but, please, make sure your custom rom is not something that makes the bug happened. I really started to think that any issue you post can be considered as a custom rom bug.
avently
on 7 Sep 2020
And yes, you can unlable Unified player because it's not related to Unified player even if you prove that the problem with NewPipe itself
avently
on 7 Sep 2020
And always, _always_ state only one bug/feature per issue.
opusforlife2
on 7 Sep 2020
@avently @opusforlife2 not this time the phone doesn't use a custom rom !
panacist
on 7 Sep 2020
and what's wrong with using a custom rom ? i use replicant os and you should guys try to have support for it (just as you do with the current version(partially at least)) ? i mean it's free software and everything so it deserves the support
panacist
on 7 Sep 2020
Most custom ROMs work fine, but I think Replicant in particular might have issues because of disabling non-free codecs, as avently said. If your phone doesn't have a decoder for VP9 (and no phone has an AV1 decoder) then you need an H.264 decoder, which is probably proprietary.
opusforlife2
on 7 Sep 2020
and what's wrong with using a custom rom ?
No one wants to deal with a badly working OS. We make software, not fixing custom rom issues.
avently
on 7 Sep 2020
@opusforlife2
i just keep wondering why the current version actually loads the videos (well using webm) while the unified player just crashes everything !!
@avently
yeah absolutley it's not your problem but i think most of the people who don't want to use the youtube proprieatry app actually are using a custom rom (lineage os is a popular one) so providing a way around is always a good step and a huge learning expirience.
panacist
on 7 Sep 2020
and apart from all of this can you please tell me what is the difference between the share icon and the globe(earth?) icon (aren't they doing the same function?)
The globe icon is to open the video in your default browser. The Share button will bring up the share sheet. What happens in your case?
opusforlife2
on 7 Sep 2020
@panacist Does issue 2 happen with 0.19.8?
opusforlife2
on 7 Sep 2020
@opusforlife2
The globe icon is to open the video in your default browser. The Share button will bring up the share sheet. What happens in your case?
on android 5 it opens the "share with" thing but with fewer options(chiefly chrome, youtube ,newpipe itself and internet browser) than the share button.
@panacist Does issue 2 happen with 0.19.8?
as far as i know nope it doesn't happen
panacist
on 8 Sep 2020
Have you set a default browser?
as far as i know
Check, dude. Narrow it down.
opusforlife2
on 8 Sep 2020
@opusforlife2
Have you set a default browser?
yup did so !
Check, dude. Narrow it down.
did check and yup yup it doesn't happen as i said before
panacist
on 8 Sep 2020
Second thing is reproducible, the first - not.
avently
on 8 Sep 2020
Sorry, you're saying you can reproduce Issue 2, avently?
opusforlife2
on 8 Sep 2020
yep, fixed it already.
avently
on 8 Sep 2020
Damn, you're too fast. XD
Edit: what was the cause?
opusforlife2
on 8 Sep 2020
what was the cause?
https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/layout/player.xml#L358
avently
on 8 Sep 2020
Ah. And appcompat is used for Android versions below...?
opusforlife2
on 8 Sep 2020
Problem is padding, not AppCompat
avently
on 8 Sep 2020
No I got that, but panacist has Lollipop, and this problem didn't appear on newer Android versions. So appcompat was needed for Android 5? 6?
opusforlife2
on 8 Sep 2020
@opusforlife2 I have no idea why it's used here. Maybe for 4.4 because the slider will look old-fashioned on 4.4
avently
on 8 Sep 2020
on android 5 it opens the "share with" thing but with fewer options(chiefly chrome, youtube ,newpipe itself and internet browser) than the share button.
Ah. Default apps were introduced in Android 6, which is why the globe button is giving him multiple options. Is this expected behaviour or can something be done about it?
opusforlife2
on 8 Sep 2020
I don't know and not interested in making something with it
avently
on 8 Sep 2020
yep, fixed it already.
Alright. Please link the PR fix for Issue 2 to this one whenever you're done with it, since Issue 1 and 3 have been discussed and are not a problem.
opusforlife2
on 8 Sep 2020
@panacist Again, make sure you only open one issue per item in the future.
opusforlife2
on 8 Sep 2020
@opusforlife2
on android 5 it opens the "share with" thing but with fewer options(chiefly chrome, youtube ,newpipe itself and internet browser) than the share button.
So this is how it should work everywhere, because youtube link can be opened in browser, in youtube and in newpipe. this is how it works on every phone, even on 4.4. Share button shows more options
avently
on 8 Sep 2020
Oh weird. I have Fenix Nightly as my default browser and tapping the globe directly opens it in Fenix. But if I change my default browser to Fennec, then I get the "Share with" menu containing apps which can open the link.
opusforlife2
on 8 Sep 2020
@opusforlife2
@panacist Again, make sure you only open one issue per item in the future.
SIR YES SIR!!
I get the "Share with" menu containing apps which can open the link.
yeah that's why i though it's a bug or something at first
panacist
on 9 Sep 2020
see #4272
avently
on 11 Sep 2020
Related issues
ghost
路
3Comments
B0pol
路
3Comments
fnadde42
路
3Comments
ghost
路
3Comments
desmonk
路
3Comments
Most helpful comment
Don't get me wrong but, please, make sure your custom rom is not something that makes the bug happened. I really started to think that any issue you post can be considered as a custom rom bug.