Newpipe: 0.19.3 instant crash

[sh3zb0t]

Exception

• __User Action:__ ui error
• __Request:__ App crash, UI failure
• __Content Language:__ en_GB
• __Service:__ none
• __Version:__ 0.19.3
• __OS:__ Linux motorola/channel_reteu/channel:9/PPY29.105-134/e13ed:user/release-keys 9 - 28
• set the language to polish
  (havent tested other languages yet)
• try to load "whats new page"

Crash log

java.util.FormatFlagsConversionMismatchException: Conversion = s, Flags = 
    at java.util.Formatter$FormatSpecifier.failMismatch(Formatter.java:4398)
    at java.util.Formatter$FormatSpecifier.checkBadFlags(Formatter.java:3091)
    at java.util.Formatter$FormatSpecifier.checkGeneral(Formatter.java:3049)
    at java.util.Formatter$FormatSpecifier.(Formatter.java:2816)
    at java.util.Formatter$FormatSpecifierParser.(Formatter.java:2624)
    at java.util.Formatter.parse(Formatter.java:2557)
    at java.util.Formatter.format(Formatter.java:2504)
    at java.util.Formatter.format(Formatter.java:2458)
    at java.lang.String.format(String.java:2883)
    at android.content.res.Resources.getString(Resources.java:466)
    at androidx.fragment.app.Fragment.getString(Fragment.java:873)
    at org.schabi.newpipe.local.feed.FeedFragment.updateRefreshViewState(FeedFragment.kt:283)
    at org.schabi.newpipe.local.feed.FeedFragment.updateRelativeTimeViews(FeedFragment.kt:273)
    at org.schabi.newpipe.local.feed.FeedFragment.onResume(FeedFragment.kt:83)
    at androidx.fragment.app.Fragment.performResume(Fragment.java:2649)
    at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:922)
    at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1238)
    at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1303)
    at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:439)
    at androidx.fragment.app.FragmentManagerImpl.executeOps(FragmentManagerImpl.java:2079)
    at androidx.fragment.app.FragmentManagerImpl.executeOpsTogether(FragmentManagerImpl.java:1869)
    at androidx.fragment.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManagerImpl.java:1824)
    at androidx.fragment.app.FragmentManagerImpl.execPendingActions(FragmentManagerImpl.java:1727)
    at androidx.fragment.app.FragmentManagerImpl$2.run(FragmentManagerImpl.java:150)
    at android.os.Handler.handleCallback(Handler.java:873)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:193)
    at android.app.ActivityThread.main(ActivityThread.java:6923)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:870)

---

[androidSwDev099]

@sh3zb0t,
NewPipe team wants us to use templates here https://github.com/TeamNewPipe/NewPipe/issues/new/choose
and use
https://teamnewpipe.github.io/CrashReportToMarkdown/

[wb9688]

That's caused by the space between the % and the s in https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/values-pl/strings.xml#L593. There are similar issues in other places for other languages.

@TobiGr: We really need to check this kind of stuff somehow.

Edit: To check this in Android Studio: Analyze -> Inspect Code, and then under Android -> Lint -> Correctness -> Messages -> Formatting arguments incomplete or inconsistent, and Invalid format string

[TobiGr]

@wb9688 I'll write some basic tests tonight

[wb9688]

These are currently wrong in NewPipe. Everyone could fix them on Weblate. I didn't check if anyone fixed anything on Weblate (or messed up more) though.