Newpipe: Is the trending page supposed to look like this ?

[cool-student]

• [x] I carefully read the contribution guidelines and agree to them.
• [x] I checked if the issue/feature exists in the latest version.
• [ ] I did use the incredible bugreport to markdown converter to paste bug reports.

I'm on Android 10.

this is what it looks like before 0.18.5

this is what it looks like in 0.18.5:

is this intentional ?

[wb9688]

Could you tell me what countries/languages you've set in Settings->Content.

[wb9688]

Never mind, this happens in the UK. This is semi-intentional, but should be fixed. It's caused by that "Munya Chawawa" thing you currently see on YouTube's new site.

[mauriciocolli]

Saw this as well, don't know why an issue was not opened for this release (as usual), specially because it brings a big change.

Anyway, here's why:

[...]
@Nonnull
@Override
public InfoItemsPage<StreamInfoItem> getInitialPage() {
    StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId());
    JsonArray firstPageElements = initialData.getObject("contents").getObject("twoColumnBrowseResultsRenderer")
            .getArray("tabs").getObject(0).getObject("tabRenderer").getObject("content")
            .getObject("sectionListRenderer").getArray("contents").getObject(0).getObject("itemSectionRenderer")
            .getArray("contents").getObject(0).getObject("shelfRenderer").getObject("content")
            .getObject("expandedShelfContentsRenderer").getArray("items");

[...]

There's more items within the initialData. A more efficient solution would be to traverse all the objects and get the videoRenderer ones.

Unfortunately I don't have the time to open a pull request right now, if nobody does this I'll try to do it later.

[wb9688]

@mauriciocolli: I'll do it as part of TeamNewPipe/NewPipeExtractor#262.

[B0pol]

I've noticed it doesn't happen with all countries (try china (hongkong))

[wb9688]

@B0pol: That's true, else I would've caught it earlier. ;)

However I already fixed it now in https://github.com/TeamNewPipe/NewPipeExtractor/pull/262/commits/db305408e906614fbdff44d963fc94aed1363c9c.