Newpipe: Release v0.18.4

[Stypox]

New

• Added language selector to change the app language #2921
• Added send to Kodi button to player collapsible menu #2310
• Added ability to copy comments on long press #3053

Improved

• Fix ReCaptcha activity and correctly save obtained cookies #3035
• Remove dot-menu in favour of drawer and hide history button when "Watch history" is not enabled in settings #2960
• Ask for display over other apps permission in settings correctly on Android 6 and later #3004
• Rename local playlist by long-clicking in BookmarkFragment #2954
• Various PeerTube improvements #3044 :
  
  
  
  • Display full description instead of truncated
  
  
  • Handle age limit
  
  
• Improved several English source strings #2938

Fixed

• Fixed player starting again although it is paused when option "minimize on app switch" enabled and NewPipe is minimized #2917
• Fixed .srt subtitle downloads containing not all line breaks #2957
• Fixed download to SD card failing because some Android 5 devices are not CTF compliant #2958
• Fixed downloading on Android KitKat #3032
• Fixed corrupt video .mp4 file being recognized as audio file #2959
• Fixed wrong Chines language codes #2865
• Fix initial brightness value for gesture #3102
• Fixed corrupt mp4 downloads #3117
• [YouTube] Timestamps in description are clickable again #3044

---

APK for testing: RC1

app-debug_RC1.zip
PULL REQUEST #3113

PLEASE REPORT ONLY NEW BUGS BELOW

[Stypox]

@TobiGr should I also add NewPipeExtractor changelog here?

[aaazv]

Do u have a telegram group?

[aaazv]

when will this bug of recaptcha get fixed?

[garawaa]

Please make it possible to download songs from soundcloud by sharing to
newpipe.

On Thu, Feb 20, 2020, 14:09 aaazv <[email protected] wrote:

when will this bug of recaptcha get fixed?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TeamNewPipe/NewPipe/issues/3114?email_source=notifications&email_token=ABDMWVNOWGDKKTQXDAV4GO3RDYF7NA5CNFSM4KYAQDH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKYGWI#issuecomment-588612441,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDMWVPTVGSJBNVNTXUM7CLRDYF7NANCNFSM4KYAQDHQ
.

[Stypox]

@aaazv no, we don't have a Telegram group, see #2965
Recaptchas have been fixed in this version. Please post here only new issues you find in the provided RC apk.

@garawaa that's not a new bug related to this release and to the provided RC apk, but is just a feature request. There are already issues open for it.

[cool-student]

@Stypox
~I think we should merge https://github.com/TeamNewPipe/NewPipe/pull/3099 since it fixes a regression introduced in https://github.com/TeamNewPipe/NewPipe/pull/2959~
thanks

[TobiGr]

@TobiGr should I also add NewPipeExtractor changelog here?

@Stypox No. Thank you for taking care of this release. I have a changelog file, but I am waiting for #3098 and #3099 before I push it. Btw, please create a new branch for a release as described in the our docs next time. I forgot to point that out yesterday :)

[aaazv]

Can u tell me when will this be released?

[Poolitzer]

if you need it now, download the debug apk

[opusforlife2]

@aaazv Yep. As @Poolitzer said, you can use the debug APK if it's urgent. It will install separately from the main app, and you can continue to use the debug app until the new version is released officially.

[aaazv]

A problem.

As I close every app as "kill foreground app", whenever I try to open a utube video with newpipe again, the video doesnt come the first time. the forst attempt, the app shows up on the default page, what ever it is, then u have to click on the link again to see the video in newpipe.
I checked this with official app and its not like this.
Can u fix this that even if the app is closed from the base, when it opens with a link, to go directly to the link and not to the main page?

This bothers a little.
Another thing is that the videos dont load sometimes and the rest of the time, load slower than other apps.

But still, its better than vanced or snaptube or original app. thanks.

[Poolitzer]

How do you try to open it.

[aaazv]

By searching a video in google and clicking on a vid coming up in search results. Then it asks me to open woth chrome or newpipe, I choose newpipe.

This way, first the app starts without showing the content I want and I have to click on the link again and it shows the vid as the app has started now.

[Stypox]

@aaazv is this a new bug introduced by this release? If not, please open a new issue

Anyway, we would need the device model and OS, and it would help if you intercepted the "open" intent using Intent Intercept: https://f-droid.org/app/de.k3b.android.intentintercept

[opusforlife2]

GUYS! REGRESSION!

Remove dot-menu in favour of drawer

I thought this setting would replace the dot menu with the drawer everywhere. Turns out that it just removes the dot menu. The drawer is only accessible from the home screen.

If you must remove the dot menu, please make the drawer accessible from all screens.

Edit: as an example, suppose you want to switch from WebM to MPEG-4 for a video, now you have to go all the way back to the home screen, change the setting, then search for the video again, losing all your back button history (I forgot what it's called).

[B0pol]

I don't think you need to access settings everywhere, why would you?

I've watched the behavior on some other app, and all are the same : you can only access drawer on main page. If you are in a subactivity (ie there is a back button in appbar), you can't access settings.

[opusforlife2]

If you are in a subactivity (ie there is a back button in appbar), you can't access settings.

Not true. Play Store > My apps & games has the back button, yet the side drawer is accessible.

Anyway, why would you want to take functionality _away_ from the user?

[Stypox]

@TobiGr what should we do about this menu issue? The only button needeed from everywhere is probably "Settings", so we could add it back.

[opusforlife2]

I think there is nothing wrong with the direction this is going in. If you were to ask me what I preferred, dot menu or sidebar, I would choose sidebar. Is it difficult to make it accessible on other screens?

[ShareASmile]

But, why dot menu is being removed in first place, a function that i use routinely.

.. a dot menu one touch away is so helpful.

[Stypox]

I found an issue in this release: pressing "Switch to Popup" in the background player queue activity generates a crash. I tried to look into it but I was not able to understand why this happens and how to fix it. Switching to MainPlayer works, and switching from MainPlayer to other players works. @TobiGr

Exception

• __User Action:__ ui error
• __Request:__ App crash, UI failure
• __Content Language:__ en_GB
• __Service:__ none
• __Version:__ 0.18.4
• __OS:__ Linux Android 7.0 - 24

Crash log

android.content.ActivityNotFoundException: Unable to find explicit activity class {org.schabi.newpipe.debug/org.schabi.newpipe.player.PopupVideoPlayer}; have you declared this activity in your AndroidManifest.xml?
    at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1850)
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1544)
    at android.app.ContextImpl.startActivity(ContextImpl.java:885)
    at android.app.ContextImpl.startActivity(ContextImpl.java:855)
    at android.content.ContextWrapper.startActivity(ContextWrapper.java:356)
    at org.schabi.newpipe.player.ServicePlayerActivity.switchTo(ServicePlayerActivity.java:199)
    at org.schabi.newpipe.player.BackgroundPlayerActivity.onPlayerOptionSelected(BackgroundPlayerActivity.java:58)
    at org.schabi.newpipe.player.ServicePlayerActivity.onOptionsItemSelected(ServicePlayerActivity.java:171)
    at android.app.Activity.onMenuItemSelected(Activity.java:3356)
    at androidx.fragment.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:384)
    at androidx.appcompat.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:219)
    at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:109)
    at androidx.appcompat.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:109)
    at androidx.appcompat.app.ToolbarActionBar$2.onMenuItemClick(ToolbarActionBar.java:64)
    at androidx.appcompat.widget.Toolbar$1.onMenuItemClick(Toolbar.java:207)
    at androidx.appcompat.widget.ActionMenuView$MenuBuilderCallback.onMenuItemSelected(ActionMenuView.java:781)
    at androidx.appcompat.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:840)
    at androidx.appcompat.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:158)
    at androidx.appcompat.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:991)
    at androidx.appcompat.view.menu.MenuPopup.onItemClick(MenuPopup.java:128)
    at android.widget.AdapterView.performItemClick(AdapterView.java:313)
    at android.widget.AbsListView.performItemClick(AbsListView.java:1201)
    at android.widget.AbsListView$PerformClick.run(AbsListView.java:3195)
    at android.widget.AbsListView$3.run(AbsListView.java:4138)
    at android.os.Handler.handleCallback(Handler.java:761)
    at android.os.Handler.dispatchMessage(Handler.java:98)
    at android.os.Looper.loop(Looper.java:156)
    at android.app.ActivityThread.main(ActivityThread.java:6523)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:942)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:832)

---

[opusforlife2]

pressing "Switch to Popup" in the background player queue activity generates a crash

Confirmed.

[TobiGr]

Uh. I guess this was introduced by #2917. I'll look into it tonight :(

[TobiGr]

I reverted ef90493c27af898d8e79adbb5e8d449ef5d0ae35 partly in 0bc769b9714db1fa163b41d07d52f6f1a2adfcaa. This fixes the crash for me, but does not introduce the old buggy behaviour. Here is the last RC for this release: NewPipe_v0.18.4_RC3.zip
CC @opusforlife2 @Stypox

[Stypox]

Mmmh, strange, we will have to look into this after the release... Anyway, the apk works for me, thanks for looking into it :-).

[opusforlife2]

Confirmed. Crash fixed. Release time!

[opusforlife2]

By the way, @Stypox I downloaded mauricio's PR 2309 apk. He renamed the package. If you could encourage other PR authors to rename their apks as well, we could test multiple apks side by side without having to go through the hassle of uninstalling and reinstalling.

[TobiGr]

@opusforlife2 Good idea. We might want to add this information to the contribution guidelines and to the pull request teplate. Btw.. we should also create more issue templates. One for bug reports and one for feature requests

[Stypox]

Yeah, great idea. What about adding a ".branchname" at the end of the app signature, only if the current branch name is not "master" or "dev"? Also, we could set the app name to "NewPipe branchname" with the rules above. This should be doable with gradle.

[Poolitzer]

@tobiGR I wanted to do those templates anyway, can do that in a bit (after I updated the blog post)

[TobiGr]

New version is released.