Newpipe: Preload queue for offline viewing

[a-raccoon]

Having a queue where videos are buffered completely and then played anytime (even offline) would help people who have an oscillating internet connection, letting them load as much content as they can when the internet is up and just viewing what has already been buffered if the internet is down

[a-raccoon]

If possible, detect if TCP sessions time out frequently and adjust for more aggressive timeout and reconnect values. Ie, on really poor and congested wifi/mesh networks. Instead of the defacto 120 second timeout, switch to a 4 second timeout to reconnect?

[theScrabi]

When I'm about to re implement downloading I want to display the downloaded videos in NewPipe. That may help. For now your only option is to just download the videos as they are.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[opusforlife2]

@Redirion Regarding the "aggressive buffering" part, is it possible to buffer the whole video in Exoplayer?

[Redirion]

@opusforlife2

per default ExoPlayer buffers up to 32mb or up to 50 seconds, whichever of both is reached first. NewPipe has set the latter to 60 seconds.

But in my opinion what we really need is to solve issue #478

[opusforlife2]

Yup. #478 would also enable us to address the second part of this issue: creation of queues for offline viewing.

So does there have to be a fixed value for the buffer or can it be set to whatever the video length/size is?

[Redirion]

it is a fixed value that must be set on instance creation of the ExoPlayer. It cannot be changed dynamically.

[opusforlife2]

So the offline queue is the only (and better, really) solution.

[opusforlife2]

https://github.com/TeamNewPipe/NewPipe/blob/b7f50c3e124365b75fa28df5af64f94f32b10ab2/app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java#L284

What happens if getPlaybackOptimalBufferMs is set to a very large value like 5 minutes? Or exposed to the user for customisation? They might want to select 10 minutes or 30 seconds.

[Redirion]

could be used, but then we need to also increase the target buffer size accordingly, as the change would not have an effect else-wise. This also sounds like an option for expert users or rarely needed at all. In general the owners of NewPipe have been reluctant in adding more settings that don't offer anything for most users.

[Stypox]

So closing this as a too-niche feature in favour of #478

[Stypox]

The queue for offline viewing part is original though, sorry ;-)