Neovide: Too many files open issue

[smit2909]

Describe the bug
After a working on a project..for a sufficiently long time, i'd say 15 minutes or more, too many files open issue starts popping up. I dont get this issue while using neovim in terminal.

To Reproduce
Steps to reproduce the behavior:

1. Open neovide, I opened a django project, only 3 active buffers. ( I reckon more buffers will help reproduce this issue)
2. Then after some editing, this issue will pop

Desktop (please complete the following information):

• OS: Ubuntu 20.10
• Neovide Version: Branch 755-scale-artifacts from the fork of last-partizan, but the issue was persistent in the master branch of this repo as well
• Neovim Version 0.5

Please run neovide --log and paste the contents of the .log file here:
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:39:34: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:40:29: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:41:29: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:42:29: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:43:29: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:44:27: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:45:27: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:46:27: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:47:27: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:48:29: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: string literal is not a valid UTF-8 string
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: too many errors
xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: failed to parse file
Ignored client type property: "methods"
Ignored client type property: "attributes"
thread 'tokio-runtime-worker' panicked at 'Focus Gained Failed: NeovimError(Some(0), "Vim(call):E903: Process failed to start: too many open files: \"/usr/bin/sh\"")', src/bridge/ui_commands.rs:114:18
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Additional context

1. After this issue, write process becomes unbearably slow. On a small file of mere 100 lines, it takes about 2-3 to write.
2. I am using autoformatter for formatting python files on save. I tried disabling it, it does not help. This is issue does occur when neovide is freshly started. after sometime it starts giving this too many files open error and becomes sluggish
3. Keep a buffer open for longer times and then observe the write times. It increases if the buffer is old.
4. I will test this and keep adding logs and screenshots as i encounter this. I have been facing this issue since i started using neovide.

After pressing enter, the error dissappears, and if try to write using :w after it, error popups up again..more severly

[Kethku]

This seems like an upstream issue. But theres some things that would help to isolate it:

1. I'm guessing you tried, but does this repro in terminal vim?
2. Could you try to repro with another multigrid enabled gui such as https://github.com/akiyosi/goneovim (great project btw :D)
3. What about without your vim config. Does it happen then?

[PyGamer0]

Can you remove gitgutter and see if you can reproduce the issue??

[smit2909]

Can you remove gitgutter and see if you can reproduce the issue??

I tried removing git gutter, but the same kind of error pops up for a different plugin. I will remove git gutter for the day and try to reproduce the issue.

@Kethku

1. I tried in terminal vim, never encountered this error.
2. I haven't tried goneovim though..i will test using that and keep you updated. If this issue is solved i cant see myself going back to terminal vim, Kudos to all contributors!
3. Without vim config,..do you mean i should try it vanilla neovim and no plugins?

[Kethku]

1. That figures. I think it has to do with multgrid somehow
2. That would be a good thing to try as goneovim has a good multigrid implementation. To my knowledge not many of the other guis do it correctly
3. Yes. Please try with neovide -- --clean

[smit2909]

1. I tried with no git gutter plugin today. Did not get that error but found consistent crashing of neovide, after some arbitrary time of use, with below error.
2. Will keep testing without the plugin for another day and then I will jump to goneovim then and try using that with gitgutter. I did use it briefly, did not throw me any errors, but i would like to verify it by using it for a full day of work with git gutter.

error i got that crashed neovide..multiple times..reproducible everytime

• Fish Shell
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:39:34: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:40:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:41:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:42:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:43:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:44:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:45:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:46:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:47:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:48:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: too many errors
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: failed to parse file
  Ignored client type property: "methods"
  Ignored client type property: "attributes"
  ko^[^[fish: Job 1, “/home/smit/neovide_source/neovi…” terminated by signal SIGSEGV (Address boundary error)

• I also tried neovide with bash shell, just to cross verify, crashed with below error
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:39:34: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:40:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:41:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:42:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:43:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:44:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:45:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:46:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:47:27: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:48:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: string literal is not a valid UTF-8 string
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: too many errors
  xkbcommon: ERROR: /usr/share/X11/locale/iso8859-1/Compose:49:29: failed to parse file
  Ignored client type property: "methods"
  Ignored client type property: "attributes"
  j[1] 96366 segmentation fault (core dumped) /home/smit/neovide_source/neovide/target/release/neovide

[smit2909]

@Kethku

• I could not get the gitgutter like too many files open issue, but just like yesterday, it consistently kept crashing on me. I ran neovide with --logs args and found below logs. I tried with different shells, terminals, etc. It is consistently reproducible. Just crashes after a some time of use or idle.

Ignored client type property: "methods"
Ignored client type property: "attributes"
Ignored style attribute: "fg_indexed"
Ignored style attribute: "fg_indexed"
Ignored style attribute: "fg_indexed"
Ignored style attribute: "fg_indexed"
Ignored style attribute: "fg_indexed"
Ignored style attribute: "fg_indexed"
thread 'main' panicked at 'called Result::unwrap() on an Err value: Os { code: 4, kind: Interrupted, message: "Interrupted system call" }', /home/smit/.cargo/git/checkouts/winit-cdba476763ae8f28/3b5462e/src/platform_impl/linux/x11/mod.rs:396:54
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace