Neovide: Crashes when Monitor Disconnects

[Kethku]

[Kethku]

Fixed

[Kethku]

No longer crashes, but freezes instead...

[Kethku]

This should probably wait until I can rebase on upstream skulpin instead of my hacky fork

[vivlim]

I'm hitting this very often when I do something that changes display geometry (i.e. reconnect to my RDP session after overnight) which results in the majority of my neovim sessions not closing cleanly, which results in my oldfiles not being updated :(

Is there anything I can do to help with this one?

[j4qfrost]

We could start implementing a feature for saving changes on crashes as a temporary measure, but I would imagine this would have a much broader use case. I know Sublime Text has this feature.

[Kethku]

This is most definitely a bug which should be raised upstream in skulpin. I will make an issue and start some debugging.

An auto saving feature seems interesting, but I'm nervous that for some users saving temporary files might not be desirable?

Further at the moment neovide doesn't even detect the crash which makes this harder...

[Kethku]

Also the upstream to skulpin is done now. So the above comment https://github.com/Kethku/neovide/issues/147#issuecomment-591702037 is no longer valid

[Kethku]

https://github.com/aclysma/skulpin/issues/47 Upstream issue is here

[vivlim]

Are there flags I can pass to neovide that will collect the relevant logs?

[j4qfrost]

--log

[vivlim]

Log attached, but there doesn't seem to be anything of note in here.
neovide_rCURRENT.log

I'm running the windows build produced by this action run: https://github.com/Kethku/neovide/actions/runs/95481207
Unfortunately, I can't get a stack trace from the dump because the action doesn't publish .pdbs. I'm setting up my environment to build neovide and I'll collect more information about where it's crashing.

[j4qfrost]

Further at the moment neovide doesn't even detect the crash which makes this harder...

Forgot about that. Looks like this requires more print statements.

[vivlim]

Here's the stack trace I'm seeing. I was hoping I'd be able to get symbols for nvoglv64.dll from the nvidia symbol server, but no luck.

If you have any logging changes you'd want me to apply and repro with, I can do that.

[Kethku]

@vivlim I just confirmed that the skulpin sdl2 example https://github.com/aclysma/skulpin/blob/master/examples/interactive_sdl2.rs exhibits the exact same issue (as far as I can tell).

[Kethku]

Discussion here: https://gitter.im/neovide/community seems to indicate that the problem is indeed upstream

[Kethku]

I believe this is fixed by https://github.com/aclysma/skulpin/pull/49 trying now

[Kethku]

Yup! On windows this no longer crashes! Once the pr merges we can update the version and close this bug. @vivlim after that happens could you try on other platforms?

[vivlim]

I changed the reference to neovide to point to aclysma/skulpin (https://github.com/vivlim/neovide/tree/point-skulpin-at-upstream) and found the following

• Windows: I was able to repro the issue, and it went away after taking the upstream change
• Linux (Ubuntu 19.10 / Intel): I wasn't able to repro the issue, no noticeable change either way.
• Mac (10.15.3): I wasn't able to repro the issue, but I wasn't able to run neovide after pointing to upstream skulpin. I tried to narrow it down with one of the skulpin examples and found https://github.com/aclysma/skulpin/issues/50

[vivlim]

Looks like the reason I wasn't able to run neovide on the Mac is because the vulkan debug layer was enabled and something's broken about my vulkan-sdk install. Disabling the debug layer allowed it to run, and everything seems fine.

[Kethku]

This is now fixed. Closing